Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the documentation of registry.Reference #332

Closed
shizhMSFT opened this issue Sep 23, 2022 · 1 comment · Fixed by #358
Closed

Revisit the documentation of registry.Reference #332

shizhMSFT opened this issue Sep 23, 2022 · 1 comment · Fixed by #358
Assignees
@nima
Labels
documentation Improvements or additions to documentation
Milestone
v2.0.0-rc.5

Comments

@shizhMSFT
Copy link
Contributor

The documentation of registry.Reference mismatched its actual functionality. That is, reference not only reference a resource of descriptor but also reference a resource of repository where the Reference is an empty string.
@shizhMSFT shizhMSFT added this to the v2.0.0-rc.4 milestone Sep 23, 2022
@shizhMSFT shizhMSFT mentioned this issue Sep 23, 2022
Merged
@nima
Copy link
Contributor

nima commented Sep 23, 2022

Please assign to me and I'll fix.

@yizha1 yizha1 added the documentation Improvements or additions to documentation label Nov 7, 2022
nima added a commit to nima/oras-go that referenced this issue Nov 8, 2022
@nima
fix: Reference struct's annotation; closes oras-project#332
0c29a49 
Signed-off-by: Nima Talebi <[email protected]>
@shizhMSFT shizhMSFT mentioned this issue Nov 10, 2022
Merged
nima added a commit to nima/oras-go that referenced this issue Nov 10, 2022
@nima
doc: revise doc of registry.Reference
1e9bbdd 
This change closes oras-project#332 and oras-project#358.

Signed-off-by: Nima Talebi <[email protected]>
nima added a commit to nima/oras-go that referenced this issue Nov 10, 2022
@nima
doc: revise doc of registry.Reference
07109ca 
This change closes oras-project#332 and oras-project#358.

Signed-off-by: Nima Talebi <[email protected]>
nima added a commit to nima/oras-go that referenced this issue Nov 10, 2022
@nima
doc: revise doc of registry.Reference; closes oras-project#332
b82e5a9 
Signed-off-by: Nima Talebi <[email protected]>
shizhMSFT pushed a commit that referenced this issue Nov 11, 2022
@nima
doc: revise doc of registry.Reference (#358)
74eeb52 
Closes #332

Signed-off-by: Nima Talebi <[email protected]>
@shizhMSFT shizhMSFT moved this to Done in ORAS-Planning Nov 11, 2022
@shizhMSFT shizhMSFT modified the milestones: v2.0.0-rc.6, v2.0.0-rc.5 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nima nima

Labels
documentation Improvements or additions to documentation
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v2.0.0-rc.5
Development

Successfully merging a pull request may close this issue.

doc: revise doc of registry.Reference nima/oras-go
3 participants
@nima @shizhMSFT @yizha1