Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rb_enc_interned_str_cstr isn't implemented #3408

Closed
tenderlove opened this issue Jan 24, 2024 · 3 comments
Closed

rb_enc_interned_str_cstr isn't implemented #3408

tenderlove opened this issue Jan 24, 2024 · 3 comments

Comments

@tenderlove
Copy link
Contributor

Hi, I want to use rb_enc_interned_str_cstr but it seems like that function isn't available on Truffle Ruby so our build fails. Would it be possible to implement that please?

Thanks.

@eregon
Copy link
Member

eregon commented Jan 25, 2024

Thanks, we'll add it soon.
However I see https://github.com/sparklemotion/sqlite3-ruby/actions/runs/7647176710/job/20837558139?pr=486 uses the latest release and not truffleruby-head, so you might either want to switch to truffleruby-head in that CI (or wait the next release) or use have_func to check if it's available + fallback (e.g. rb_str_new* + rb_funcall(str, "-@") (rb_fstring is unfortunately not public although TruffleRuby does implement it).

@eregon eregon self-assigned this Jan 25, 2024
@tenderlove
Copy link
Contributor Author

have_func to check if it's available + fallback (e.g. rb_str_new* + rb_funcall(str, "-@") (rb_fstring is unfortunately not public although TruffleRuby does implement it).

ah great. I'll do this. Thank you!

@andrykonchin
Copy link
Member

andrykonchin commented Feb 14, 2024

Fixed in 88cbf96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants