Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

caps: wishlists and filling gaps #1

Closed
lucab opened this issue Jun 29, 2017 · 4 comments
Closed

caps: wishlists and filling gaps #1

lucab opened this issue Jun 29, 2017 · 4 comments
Assignees

Comments

@lucab
Copy link

lucab commented Jun 29, 2017

Hi, caps-rs author here. I was happily looking at your usecase, trying to identify existing gaps and bits that can be incorporated directly in the lib.

So far I think I have seen:

  • adding a serde-derive for Serialize/Deserialize directly on caps::Capability
  • adding some kind of all() returning a full hashset

Both seems reasonably feasible and easy to add. Any other feedback on it?

@lucab
Copy link
Author

lucab commented Jun 29, 2017

While at it, I think so far you are the first and only consumer of that crate. To increase its bus factor and keep it sane, would you be interested in comaintaining it (maintenance is very low anyway)?

I have an umbrella-org at https://github.com/camallo which already hosts several container-related crates, and caps-rs can also be moved there.

@vishvananda
Copy link
Contributor

Hi lucab. The caps crate has been very useful. I was trying to minimize external dependencies in the oci library so I didn't need to serialize caps directly. If it were serializable I could potentially use it directly in oci, but it hasn't been a huge problem. An all() would definitely be valuable. I can't speak for oracle as a whole, but I'm happy to help with caps-rs on my personal time (although I don't have a lot of it since I have a new baby).

@vishvananda
Copy link
Contributor

the newest version of the oci spec actually forces me to process all of the different types of caps individually, so an all isn't really needed any more. I think we can go ahead and close this.

@lucab
Copy link
Author

lucab commented Jul 20, 2017

Ack. I'm still planning to add all() at some point though. Also, you may be interested in reading opencontainers/runtime-spec#675 (comment) about those new sets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants