Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would really help if pre-build binaries for Node.js 12.2 would be available #1094

Closed
doberkofler opened this issue May 9, 2019 · 7 comments

Comments

@doberkofler
Copy link

Currently when installaing on 12.2 the pre-built node-oracledb binary cannot not found: oracledb ERR! NJS-067: a pre-built node-oracledb binary was not found for Node.js v12.2.0 (NODE_MODULE_VERSION=72) on win32 x64.

@cjbj
Copy link
Member

cjbj commented May 9, 2019

node-oracledb 3.1 also doesn't compile with Node.js 12, see #1085 and #1092.

If someone wants to dig in and submit a PR to us or NAN, I'd appreciate it. Otherwise we'll keep working on node-oracledb 4.0-dev, which does compile with Node.js 12, and make sure we have binaries by the time Node 12 goes LTS.

@doberkofler
Copy link
Author

Thank you!

@cjbj
Copy link
Member

cjbj commented May 17, 2019

I just pushed a commit from @anthony-tuininga to the master branch that allows it (node-oracledb 3.1) to compile with Node.js 12. You may still prefer to use the dev-4.0 branch though. The patch hasn't had full testing.

@bruce-solar
Copy link

is there a plan for testing and releasing the patch from @anthony-tuininga as a prebuilt binary?

is the intention for dev-4.0 to be backward compatible? any place i can go to find the dev-4.0 api changes?

@anthony-tuininga
Copy link
Member

You can go here for the development branch documentation. The intent is for 4.0 to be backwards compatible as much as possible. There are a few changes that will work differently with 4.0 -- but these are out-of-the-ordinary and unlikely-to-be-used scenarios, we think. Take a look at the change log and let us know if anything there looks troublesome. Thanks!

@cjbj
Copy link
Member

cjbj commented Jun 10, 2019

@bruce-solar if you want to build the 4.0-dev code, see #1053

@bruce-solar
Copy link

Thanks for the quick response. The links were helpful. And N-API is definitely good news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants