Address intermittent test failures #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous change resulted in clean builds. I've triggered them again manually to check again. |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
ljnelson
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests which exercise synthetic
@SimplyTimedannotation handling when beans are vetoed show intermittent failures.The problem turned out to be in the tests. The base registry (where, by spec, the synthetic
SimpleTimermetrics go) could be populated with syntheticSimpleTimers by earlier tests. Then, when the veto tests would run, and theMetricsCdiExtensioncode would correctly ignore vetoed beans and not add the synthetic metrics to the registry again, but the registry entries were already present from earlier tests run in the same JVM. The tests, finding those entries, would report a failure.The difference between the tests passing locally and failing in the pipeline was due to differences in the order in which surefire ran the tests.
I've added a
@BeforeAllthat clears out theREST.requestSimpleTimers to remove stale registrations, so the tests of the veto support find no syntheticSimpleTimers from previous tests.