Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MachineHealthCheck to our templates #144

Closed
joekr opened this issue Sep 9, 2022 · 1 comment · Fixed by #175
Closed

Add MachineHealthCheck to our templates #144

joekr opened this issue Sep 9, 2022 · 1 comment · Fixed by #175
Assignees
Labels
enhancement New feature or request

Comments

@joekr
Copy link
Member

joekr commented Sep 9, 2022

What would you like to be added:
We should add some basic MHC to our templates so that unhealthy nodes can be handled
MHC docs: https://cluster-api.sigs.k8s.io/tasks/automated-machine-management/healthchecking.html

We should provide a MachineHealthCheck definition for both the control-plane and the machines (excluding machine pools). We will set sane defaults for now.

For more details on this see the proposal: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20191030-machine-health-checking.md and the feature PR: kubernetes-sigs/cluster-api#3830

Why is this needed:
If a node fails to launch or is terminated for some reason we want CAPI to bring up a new node.

@joekr joekr added the enhancement New feature or request label Sep 9, 2022
@joekr
Copy link
Member Author

joekr commented Sep 9, 2022

In working with MHC I found that setting nodeStartupTimeout: 10m helps as an instance can take a while to come up. `10m1 might be too long, but we should set something higher than whatever the default is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant