Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure webhooks are compatible with CAPI 1.2 #137

Closed
randomvariable opened this issue Aug 31, 2022 · 1 comment
Closed

Ensure webhooks are compatible with CAPI 1.2 #137

randomvariable opened this issue Aug 31, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@randomvariable
Copy link

As per CAPI 1.2, the webhooks need to be changed as per the upgrade guide:
https://cluster-api.sigs.k8s.io/developer/providers/v1.1-to-v1.2.html

If infrastructure or bootstrap providers have implemented immutability checks in their InfrastructureMachineTemplate or BootstrapConfigTemplate webhooks, it is required to implement the following changes in order to prevent dry-run to return errors. The implementation requires sigs.k8s.io/controller-runtime in version >= v0.12.3.

This might not be relevant yet if we don't have immutability checks though.
@randomvariable randomvariable added the enhancement New feature or request label Aug 31, 2022
@shyamradhakrishnan
Copy link
Contributor

CAPOCI do not have the immutability check, we followed steps in the test kubernetes-sigs/cluster-api#7141 and it ran fine. So no action needed on this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randomvariable @shyamradhakrishnan