-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support human-in-the-loop via trial.user_attrs
#411
Merged
Merged
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8aadf8a
Implement human-in-the-loop via trial.user_attrs
knshnb 61b1846
Remove unnecessary directions
knshnb c7221c1
Implement register_user_attr_form_widgets
knshnb a6a48b8
Fix rendering of user_attrs
knshnb adc95b6
Update user_attrs state after saveTrialUserAttrsAPI
knshnb 5392b91
Merge remote-tracking branch 'upstream/main' into register-user-attr-…
knshnb e048b38
Format
knshnb a706421
Fix
knshnb 1144f82
Use user_attr_key by register_user_attr_form_widgets
knshnb 23c0814
Revert import format
knshnb 6ab58fa
Fix type
knshnb e85c1fd
Fix type
knshnb 8d16193
Fix import
knshnb 79bf067
Display user_attr_key for register_user_attr_form_widgets
knshnb 261a13d
Apply prettier
knshnb 9c477cb
Add validation of `user_attr_key`
knshnb 017ac67
Remove "Object" prefix from widget classes
knshnb 77ed179
Remove default text form for no widgets
knshnb 091774f
Validate user_attrs have at least one element
knshnb a5c7b59
Fix typo
knshnb 6489092
Update form widgets key name
knshnb 416c6c7
Include form_widgets_output_type in form_widgets
knshnb 765b0d3
Apply formatter
knshnb 031a1e1
Fix type
knshnb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if
FORM_WIDGETS_OUTPUT_TYPE_KEY
could be included inFORM_WIDGETS_KEY
as follows.Please see d0cb33e for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I refactored form_widgets_output_type according to your comment.