Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributes and events support to config #339

Merged
merged 11 commits into from
Jun 28, 2021
Merged

Add attributes and events support to config #339

merged 11 commits into from
Jun 28, 2021

Conversation

The-inside-man
Copy link
Contributor

Summary

  • Attributes and Events support added to config
  • Test cases added to test_optimizley_config

Test plan

  • Compatibility test

Issues

  • OASIS-7800

ozayr-zaviar and others added 9 commits June 24, 2021 08:25
@ozayr-zaviar @The-inside-man
added sdk and environment key
5461817
@The-inside-man
[MAINTENANCE] Remove Deprecated warnings during build
41aa6f2 
            - assertRaisesRegexp -> assertRaisesRegex
            - assertEquals -> assertEqual
            - isAlive() -> is_alive()
            - Check added to base.py to confirm attribute assertRaisesRegex for backwards compatibility to Python2.7
@The-inside-man
[OASIS-7757] Fix spelling of environment to fix testcases from failing
54e2c3b
@The-inside-man
[OASIS-7757] - Added additional test cases to test_optimizely and tes…
f9b6ba3 
…t_user_context.
@The-inside-man
[OASIS-7800] Updated optimizely_config with attributes and events
e12d9ae
@The-inside-man
[OASIS-7757] - update copyright years and add more testcases for sdk_…
6e51dbb 
…key and environment_key. Move decide tests to test_user_context from test_optimizely.
@The-inside-man
[OASIS-7800] Updated optimizely_config with attributes and events
5217294
@The-inside-man
Run autopep8 to fix formatting issues after rebase
69e4604
@The-inside-man
[OASIS-7800] - Added test cases for attribute map and events map
5e479a0
@The-inside-man The-inside-man requested a review from a team as a code owner June 24, 2021 16:19
@coveralls
Copy link

coveralls commented Jun 24, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 95.975% when pulling 54e9f3a on jbrown/oasis-7800_events-attributes into 9e9c4d0 on master.

Mat001
Mat001 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The-inside-man The-inside-man merged commit 2ee24cf into master Jun 28, 2021
@The-inside-man The-inside-man deleted the jbrown/oasis-7800_events-attributes branch June 28, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keppel2 keppel2 keppel2 approved these changes

@Mat001 Mat001 Mat001 approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@The-inside-man @coveralls @Mat001 @keppel2 @ozayr-zaviar