Fix data leak #218
Draft
Fix data leak #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After detailed analysis I observed that his solution only delay the memory leak, that still happens, wip investigation. |
|
@r4f4ss Thanks, I thought the bug may be here, we cached the utp packet recently, but since we can't call the function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #215
Explanation
Function handleUtpTalkRequest create UTP connections as demanded, but sometimes those connections are not closed, possibly due to peer not responding.
Proposed Solution
The function handleExpiredUtpTalkRequest in invoked after an expire time of 20 seconds and close the respective UTP connection if it is not been used.