Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid code duplication between Ax base generator class and AxModelManager #221

Open
AngelFP opened this issue Jun 11, 2024 · 0 comments
Open

Comments

@AngelFP
Copy link
Member

AngelFP commented Jun 11, 2024

There is currently some code duplication between both classes in, for example, how the trial data is given to the Ax client. A possible solution would be to turn the AxModelManager into a high-level wrapper of AxClient in optimas. In this way, the ax generators would store (and interact with) an AxModelManager instead of directly using an AxClient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant