Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chef-solo to use remote_file and other resources through proxy #192

Closed
wants to merge 4 commits into from

Conversation

scotthain
Copy link
Contributor

Allows passing of http_proxy, https_proxy, and no_proxy variables to the chef-solo solo.rb file by adding the following variables to .kitchen.yml:
chef_http_proxy: http://myproxy.com:8000
chef_https_proxy: http://myproxy.com:8000
chef_no_proxy: ".internal.corp,10."

@scotthain
Copy link
Contributor Author

As an FYI, I chose to add new variables as opposed to using the existing http_proxy and https_proxy variables due to the fact that this is Chef-solo specific, and to the best of my knowledge Vagrant doesn't support (or need?) the no_proxy option. It seemed cleaner to keep it provider agnostic and add new variables rather than overloading the 'purpose' of the existing ones.

@sethvargo
Copy link
Contributor

I think these might be better served in a nested hash:

chef
  http_proxy: #...

What do you think?

@scotthain
Copy link
Contributor Author

I like it, that adds a layer of indirection that makes it more extensible for different providers in the future. I'll try and get that put together today or tomorrow.

@sethvargo
Copy link
Contributor

@scotthain awesome thanks. Ping me when you do. Do you have a signed CLA with Opscode?

Refactored to pull in a hash rather than a straight array for chef specific proxy values
@scotthain
Copy link
Contributor Author

@sethvargo got the CLA in order and just checked in the config refactor. cheers!

@programmerq
Copy link

This would be super useful for us as well. Gotta "love" those corporate proxies. :)

@sethvargo
Copy link
Contributor

Merged in a29b476

@esciara
Copy link

esciara commented Apr 16, 2014

Changes in this pull deprecated by commit 6e30431. See comments under that commit.

@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants