Include definitions directory when uploading the cookbooks #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, I can't believe I forgot about definitions, whoops. Do you have an Opscode CLA signed by chance? |
|
When will this be available in rubygems? |
|
Sorry for the delay. @fnichol I do have a CLA signed. |
|
@jasonroelofs excellent thank you! I'm just waiting on the Opscode page to update then this is in! @sanmiguelje if not today then this pull request should be in the next couple of days 😄 |
|
@jasonroelofs Thanks again! Unfortunately the source of the fix moved, but I credited you in the currently location with a new commit (hope that's okay). |
BrentOnRails
pushed a commit
to BrentOnRails/test-kitchen
that referenced
this pull request
Jul 17, 2017
Adding block_device_mapping iops parameter, fixes test-kitchen#157
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kitchen convergewas not including the definitions directory when uploading my cookbooks into vagrant. This fixes that problem.I tried to get
cp_this_cookbookto usecookbook_files_globto reduce redundancies but was unable to get it working right.