Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bin/src/config.rs:79] [self.ignore.as_slice(), extra_ignores].concat() = [] #59

Closed
neunenak opened this issue Nov 2, 2022 · 4 comments · Fixed by #60
Closed

[bin/src/config.rs:79] [self.ignore.as_slice(), extra_ignores].concat() = [] #59

neunenak opened this issue Nov 2, 2022 · 4 comments · Fixed by #60

Comments

@neunenak
Copy link

neunenak commented Nov 2, 2022

If I run statix check on a file or directory, it prints the output:

[bin/src/config.rs:79] [self.ignore.as_slice(), extra_ignores].concat() = []

and nothing else. Looking at that line of code, I can see it is using the dbg! macro to print some debug output that doesn't seem relevant to the end user.

It looks like this might be the expected output if there are no problems with a particular nix file, but it would be nice if there was some explicit acknowledgement that there was nothing wrong with the linted files, rather than just this debug print and exiting.

@samhh
Copy link

samhh commented Sep 9, 2023

For anyone else landing here, this is still present in 0.5.6 in nixpkgs as there hasn't been a release since this was fixed.

@oppiliappan
Copy link
Owner

pushed a tag for 0.5.7 now, should be fixed 🤞

@samhh
Copy link

samhh commented Sep 9, 2023

FYI --version still says 0.5.6, probably sourced from here: https://github.com/nerdypepper/statix/blob/master/bin/Cargo.toml#L3

@oppiliappan
Copy link
Owner

nice find, i had this documented in docs/release.txt, and i still forgot haha. i dont want to delete the tag, i assum that raises issues for package maintainers, will release v0.5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants