From f996352a4dd9ef4fa6d6a5a59372f0490909a6d0 Mon Sep 17 00:00:00 2001 From: marysoloman Date: Wed, 13 Nov 2019 19:13:56 +0530 Subject: [PATCH 1/8] topic tab hi-fi UI --- .../res/color/tab_icon_color_selector.xml | 5 ++++ .../main/res/drawable/ic_play_icon_24dp.xml | 14 +++------- .../main/res/drawable/ic_review_icon_24dp.xml | 27 +++++-------------- .../main/res/drawable/ic_train_icon_24dp.xml | 27 +++++-------------- app/src/main/res/layout/topic_fragment.xml | 8 ++++-- app/src/main/res/values/styles.xml | 17 ++++++++++++ 6 files changed, 46 insertions(+), 52 deletions(-) create mode 100644 app/src/main/res/color/tab_icon_color_selector.xml diff --git a/app/src/main/res/color/tab_icon_color_selector.xml b/app/src/main/res/color/tab_icon_color_selector.xml new file mode 100644 index 00000000000..2f8fd704310 --- /dev/null +++ b/app/src/main/res/color/tab_icon_color_selector.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_play_icon_24dp.xml b/app/src/main/res/drawable/ic_play_icon_24dp.xml index abfcde6b66e..f53f1c846e7 100644 --- a/app/src/main/res/drawable/ic_play_icon_24dp.xml +++ b/app/src/main/res/drawable/ic_play_icon_24dp.xml @@ -1,11 +1,5 @@ - - + + diff --git a/app/src/main/res/drawable/ic_review_icon_24dp.xml b/app/src/main/res/drawable/ic_review_icon_24dp.xml index ff954de75ce..85b4888b842 100644 --- a/app/src/main/res/drawable/ic_review_icon_24dp.xml +++ b/app/src/main/res/drawable/ic_review_icon_24dp.xml @@ -1,21 +1,8 @@ - - - - - - + + + + + + diff --git a/app/src/main/res/drawable/ic_train_icon_24dp.xml b/app/src/main/res/drawable/ic_train_icon_24dp.xml index 04dae36da8b..8cac55f8839 100644 --- a/app/src/main/res/drawable/ic_train_icon_24dp.xml +++ b/app/src/main/res/drawable/ic_train_icon_24dp.xml @@ -1,21 +1,8 @@ - - - - - - + + + + + + diff --git a/app/src/main/res/layout/topic_fragment.xml b/app/src/main/res/layout/topic_fragment.xml index 3b65bf68ccb..333bbccf45d 100644 --- a/app/src/main/res/layout/topic_fragment.xml +++ b/app/src/main/res/layout/topic_fragment.xml @@ -22,6 +22,7 @@ android:layout_height="?attr/actionBarSize" android:background="?attr/colorPrimary" app:titleTextColor="@color/white" + android:textSize="20dp" app:popupTheme="@style/ThemeOverlay.AppCompat.Light" /> + style="@style/AppTabLayout" + app:tabTextAppearance="@style/AppTabTextAppearance" + app:tabTextColor="@color/tab_icon_color_selector" /> 14sp false + + + + From ca80c190e1deeb77a22bcf47fc2938e82ad0588b Mon Sep 17 00:00:00 2001 From: marysoloman Date: Wed, 13 Nov 2019 19:14:28 +0530 Subject: [PATCH 2/8] nit --- app/src/main/res/values/styles.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 6420a841430..94bef576fc0 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -79,6 +79,7 @@ 14sp false + - From 48bf899a1d0f43cfc9402f9cf2ad4e6fb046db55 Mon Sep 17 00:00:00 2001 From: marysoloman Date: Wed, 13 Nov 2019 19:17:37 +0530 Subject: [PATCH 3/8] nit --- app/src/main/res/color/tab_icon_color_selector.xml | 2 +- app/src/main/res/values/colors.xml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/res/color/tab_icon_color_selector.xml b/app/src/main/res/color/tab_icon_color_selector.xml index 2f8fd704310..7da1e738447 100644 --- a/app/src/main/res/color/tab_icon_color_selector.xml +++ b/app/src/main/res/color/tab_icon_color_selector.xml @@ -1,5 +1,5 @@ - + \ No newline at end of file diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml index f378cbaf477..0dc303e805a 100644 --- a/app/src/main/res/values/colors.xml +++ b/app/src/main/res/values/colors.xml @@ -27,6 +27,7 @@ #FFFFFF #CCFFFFFF + #B3FFFFFF #000000 @color/oppiaDarkBlue From 3057fabbcc9405528032f14a398039260818932b Mon Sep 17 00:00:00 2001 From: marysoloman Date: Wed, 13 Nov 2019 19:26:15 +0530 Subject: [PATCH 4/8] nit --- .../res/color/tab_icon_color_selector.xml | 2 +- .../main/res/drawable/ic_play_icon_24dp.xml | 14 +++++++--- .../main/res/drawable/ic_review_icon_24dp.xml | 27 ++++++++++++++----- .../main/res/drawable/ic_train_icon_24dp.xml | 27 ++++++++++++++----- 4 files changed, 51 insertions(+), 19 deletions(-) diff --git a/app/src/main/res/color/tab_icon_color_selector.xml b/app/src/main/res/color/tab_icon_color_selector.xml index 7da1e738447..33c81a116ae 100644 --- a/app/src/main/res/color/tab_icon_color_selector.xml +++ b/app/src/main/res/color/tab_icon_color_selector.xml @@ -2,4 +2,4 @@ - \ No newline at end of file + diff --git a/app/src/main/res/drawable/ic_play_icon_24dp.xml b/app/src/main/res/drawable/ic_play_icon_24dp.xml index f53f1c846e7..abfcde6b66e 100644 --- a/app/src/main/res/drawable/ic_play_icon_24dp.xml +++ b/app/src/main/res/drawable/ic_play_icon_24dp.xml @@ -1,5 +1,11 @@ - - + + diff --git a/app/src/main/res/drawable/ic_review_icon_24dp.xml b/app/src/main/res/drawable/ic_review_icon_24dp.xml index 85b4888b842..ff954de75ce 100644 --- a/app/src/main/res/drawable/ic_review_icon_24dp.xml +++ b/app/src/main/res/drawable/ic_review_icon_24dp.xml @@ -1,8 +1,21 @@ - - - - - - + + + + + + diff --git a/app/src/main/res/drawable/ic_train_icon_24dp.xml b/app/src/main/res/drawable/ic_train_icon_24dp.xml index 8cac55f8839..04dae36da8b 100644 --- a/app/src/main/res/drawable/ic_train_icon_24dp.xml +++ b/app/src/main/res/drawable/ic_train_icon_24dp.xml @@ -1,8 +1,21 @@ - - - - - - + + + + + + From 13be89292516837d4d03407634ab424d39ee1160 Mon Sep 17 00:00:00 2001 From: marysoloman Date: Wed, 13 Nov 2019 19:31:40 +0530 Subject: [PATCH 5/8] nit --- app/src/main/res/layout/topic_fragment.xml | 10 +++++----- app/src/main/res/values/styles.xml | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/app/src/main/res/layout/topic_fragment.xml b/app/src/main/res/layout/topic_fragment.xml index 333bbccf45d..52dc112f1e1 100644 --- a/app/src/main/res/layout/topic_fragment.xml +++ b/app/src/main/res/layout/topic_fragment.xml @@ -21,22 +21,22 @@ android:layout_width="match_parent" android:layout_height="?attr/actionBarSize" android:background="?attr/colorPrimary" - app:titleTextColor="@color/white" android:textSize="20dp" - app:popupTheme="@style/ThemeOverlay.AppCompat.Light" /> + app:popupTheme="@style/ThemeOverlay.AppCompat.Light" + app:titleTextColor="@color/white" /> diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 94bef576fc0..25411bbe293 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -94,6 +94,7 @@ From 922383966d277ff946e8b661fb4e4ae855b60de5 Mon Sep 17 00:00:00 2001 From: marysoloman Date: Wed, 13 Nov 2019 19:56:35 +0530 Subject: [PATCH 6/8] nit --- app/src/main/res/layout/topic_fragment.xml | 2 +- app/src/main/res/values/styles.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/layout/topic_fragment.xml b/app/src/main/res/layout/topic_fragment.xml index 52dc112f1e1..3ba6f688db7 100644 --- a/app/src/main/res/layout/topic_fragment.xml +++ b/app/src/main/res/layout/topic_fragment.xml @@ -20,7 +20,7 @@ android:id="@+id/toolbar" android:layout_width="match_parent" android:layout_height="?attr/actionBarSize" - android:background="?attr/colorPrimary" + android:background="@color/colorPrimary" android:textSize="20dp" app:popupTheme="@style/ThemeOverlay.AppCompat.Light" app:titleTextColor="@color/white" /> diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 25411bbe293..92b84197896 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -94,7 +94,7 @@ From 2cf9e48283568c4d3fadbc8e50802b66cab1673b Mon Sep 17 00:00:00 2001 From: marysoloman Date: Wed, 13 Nov 2019 20:08:00 +0530 Subject: [PATCH 7/8] nit --- app/src/main/res/layout/topic_fragment.xml | 4 ++-- app/src/main/res/values/styles.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/res/layout/topic_fragment.xml b/app/src/main/res/layout/topic_fragment.xml index 3ba6f688db7..5aa9bf81ae1 100644 --- a/app/src/main/res/layout/topic_fragment.xml +++ b/app/src/main/res/layout/topic_fragment.xml @@ -20,7 +20,7 @@ android:id="@+id/toolbar" android:layout_width="match_parent" android:layout_height="?attr/actionBarSize" - android:background="@color/colorPrimary" + android:background="@color/oppiaPrimaryDark" android:textSize="20dp" app:popupTheme="@style/ThemeOverlay.AppCompat.Light" app:titleTextColor="@color/white" /> @@ -31,7 +31,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:textSize="14sp" - app:tabBackground="@color/colorPrimary" + app:tabBackground="@color/oppiaPrimaryDark" app:tabGravity="fill" app:tabIconTint="@color/tab_icon_color_selector" app:tabIndicatorColor="@android:color/white" diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 92b84197896..015ae55ca3d 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -79,7 +79,7 @@ 14sp false - + - +