Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #138: Topic train fragment Low-fi UI (Part 4) #204
Fix #138: Topic train fragment Low-fi UI (Part 4) #204
Changes from 30 commits
8cdfb33
afd8196
87977ab
456d129
d21f52b
e39fa93
9ff0ff5
685bd2d
1cd605f
e30e58a
b1cef82
23e4d27
7fe1f87
3d0315a
6c5387f
5b2dc90
b9b9683
b578d34
37a4837
6321130
de7568a
7bb449b
06f03b9
dcdb082
6968d06
81eee40
9f2ad98
45b1b18
04125a0
d9f586d
1208a4a
b7fb1e4
9e81bb5
5274077
ba680a3
3d03e47
1b446ff
2e9a334
79b11ff
5b9d0dd
8a5f22f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we maybe use the one in BindableAdapterTest, instead? Prefer extracting that one to here for reuse since I think that one has all the necessary functionality, and is simpler.
Also, please add documentation and credit links where applicable (if you didn't derive this solution on your own).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to use code from
BindableAdapterTest
, but I have updated the code for better readability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I have created a custom adapter for this TopicTrainFragment, so will the
BindableAdapterTest
work with this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do we need the wrapper RecyclerViewMatcher? Could we just have a top-level Kotlin file with the atPosition method and import it where needed? The BindableAdapterTest version lends itself to this approach since it follows the standard Espresso matcher idiom of being a static-esque, standalone method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed wrapper and started using
atPosition
andatPositionView
method directly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should have brief documentation to explain how to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added brief explanation of this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is sufficient for a configuration change. Suggest instead:
ActivityScenario.recreate()
Ditto elsewhere for configuration changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means I have add this or do I have to remove the current line and replace this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using both and merge code for now, because the test-cases passes in all possible combinations, using current code only, using your code only and using both.