Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Modify Feature Flag Names to reflect those on Oppia Web #5251

Closed
kkmurerwa opened this issue Nov 29, 2023 · 6 comments
Closed
Assignees
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request.

Comments

@kkmurerwa
Copy link
Collaborator

kkmurerwa commented Nov 29, 2023

Is your feature request related to a problem? Please describe.

Some of the feature flags used to gate feature on Oppia-Android need to be updated to reflect new android-specific feature flag names from oppia-web so that remote enabling and disabling of these features is possible.

Describe the solution you'd like

The feature flag names in the FeatureFlagConstants file need to be modified and to the new respective names as shown below.

Feature Flag Current Feature Flag Name Proposed Feature Flag Name
EnableDownloadsSupport downloads_support android_enable_downloads_support
EnableExtraTopicTabsUi extra_topic_tabs_ui android_enable_extra_topic_tabs_ui
EnableLearnerStudyAnalytics learner_study_analytics android_enable_learner_study_analytics
EnableFastLanguageSwitchingInLesson fast_language_switching_in_lesson android_enable_fast_language_switching_in_lesson
EnableLoggingLearnerStudyIds logging_learner_study_ids android_enable_logging_learner_study_ids
EnableEditAccountsOptionsUi edit_accounts_options_ui android_enable_edit_accounts_options_ui
EnablePerformanceMetricsCollection performance_metrics_collection android_enable_performance_metrics_collection
EnableSpotlightUi spotlight_ui android_enable_spotlight_ui
EnableInteractionConfigChangeStateRetention interaction_config_change_state_retention android_enable_interaction_config_change_state_retention
EnableAppAndOsDeprecation app_and_os_deprecation android_enable_app_and_os_deprecation

Describe alternatives you've considered

N/A

Additional context

N/A

@kkmurerwa kkmurerwa added enhancement End user-perceivable enhancements. triage needed labels Nov 29, 2023
@kkmurerwa kkmurerwa added the good first issue This item is good for new contributors to make their pull request. label Nov 29, 2023
@kkmurerwa kkmurerwa changed the title Feature Request: Addition Of Feature Flags on Oppia Web Feature Request: Modify Feature Flag Names to reflect those on Oppia Web Nov 30, 2023
@kkmurerwa kkmurerwa removed their assignment Nov 30, 2023
@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. I decided not to do this as part of #5240 since it could be a good first issue and it poses little risk to the functionality of the rest of the codebase. Let me know what you think.

@Tejas-67
Copy link
Contributor

I would like to work on this issue. Please assign this to me.

@adhiamboperes
Copy link
Collaborator

Thanks @kkmurerwa! Looks good as a gfi.

@Tejas-67, could you please describe the changes required to solve this issue?

@Tejas-67
Copy link
Contributor

Tejas-67 commented Dec 1, 2023

@adhiamboperes the issue require changing the value of feature flags from the current name to the proposed name.
eg; from const val DOWNLOADS_SUPPORT = "downloads_support" to const val DOWNLOADS_SUPPORT = "android_enable_downloads_support"

@adhiamboperes
Copy link
Collaborator

@adhiamboperes the issue require changing the value of feature flags from the current name to the proposed name. eg; from const val DOWNLOADS_SUPPORT = "downloads_support" to const val DOWNLOADS_SUPPORT = "android_enable_downloads_support"

You can submit a draft PR for this issue. I think the issue description is already pretty specific on the required changes, @Tejas-67

@Tejas-67
Copy link
Contributor

Tejas-67 commented Dec 4, 2023

@adhiamboperes done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request.
Development

No branches or pull requests

4 participants