Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept card link is not showing up in hints. #4519

Closed
KolliAnitha opened this issue Aug 21, 2022 · 2 comments · Fixed by #4846
Closed

Concept card link is not showing up in hints. #4519

KolliAnitha opened this issue Aug 21, 2022 · 2 comments · Fixed by #4846
Assignees
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@KolliAnitha
Copy link

KolliAnitha commented Aug 21, 2022

Describe the bug
Content issue is seen for one of the hints in a question in Multi digit multiplication Part 1

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Multiplication'
  2. Click on 'Multi-Digit Multiplication, Part 1'
  3. Click on Continue till you reach the question 'There are 3829 people in our small town'
  4. Enter wrong answers to get 5hints

Expected behavior
If you need help adding numbers with carrying, take a look at this for a refresher. should be seen

Demonstration
Screenshot_2022-08-20-18-31-44-54_943a62cb4c6fb83e010e1c2e82766a17.jpg
Screenshot_2022-08-20-18-26-09-40_943a62cb4c6fb83e010e1c2e82766a17.jpg

Environment
Device name: One plus Nord2 5G
Android version : Android 11
App version : 0.8-alpha-091b45a188

@seanlip seanlip changed the title Content issue is seen for one of the hints in a question in Multi digit multiplication Part 1 Concept card not showing up in answer group feedback. Aug 21, 2022
@seanlip seanlip changed the title Concept card not showing up in answer group feedback. Concept card link is not showing up in hints. Aug 21, 2022
@seanlip
Copy link
Member

seanlip commented Aug 21, 2022

@BenHenning Confirming this is an Android platform issue and is actually quite important because we do this a lot. Can the concept card be enabled in the hints display?

@seanlip seanlip added this to the Alpha MR5 milestone Aug 21, 2022
@BenHenning
Copy link
Member

So it seems like we simply never enabled concept cards in hints. Seems like an oversight that is, fortunately, trivial to fix. We simply need to:

The only issue I see is that this will result in stacked dialogs (which is a bit of a mobile antipattern), but I don't see a good alternative. This could be, perhaps, an area for improved UX in the future.

@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@rt4914 rt4914 moved this from Needs Triage to In Progress: Being implemented in [Team] Core Learner and Mastery flows & UI Frontend - Android Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
3 participants