No enough padding on Continue button style

[Chandra-Sekhar-Bala]

Describe the bug
Continue has not enough padding when reading size changed to Extra Large

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Navigation menu' -> Select Option
2. Click on 'Reading text size' -> Select Extra Large
3. Open any lesson
4. Scroll down to click on Continue

Expected behavior
Continue button should have good padding from both ends.

Demonstration
If applicable, add screenshots or videos to help explain your problem.

Environment

• Device/emulator being used: Pixel 4 XL
• Android or SDK version: API Level 27
• App version: 1.0

[BenHenning]

@Chandra-Sekhar-Bala have you checked whether this issue repros on the latest develop? Given the recent work on this exact issue, I'd expect this to not be an issue anymore.

[Chandra-Sekhar-Bala]

Hey @BenHenning Yes, I have checked it is on the latest version. Steps are mentioned to reproduce the bug, you can verify.

[BenHenning]

@Ryggs can you look into this since #4385 was supposed to fix this issue?

[Ryggs]

Hey @BenHenning taking a look

[Chandra-Sekhar-Bala]

@BenHenning @Ryggs let me give my view on this,
Yes #4385 solved the alignment issue. But if you look into the style named @style/StateButtonActive you'll see padding attribute is missing. And that is the reason of this bug.
I hope it helps :)

[Ryggs]

@Chandra-Sekhar-Bala The padding attribute is global as we are using a wrap_content and got rid of setting a max_width, hence the button behavior

[Ryggs]

Hi @BenHenning Just checked this out and this was the fix accepted by C/O @rt4914 . What would be the workaround here? The text fits overlay when in text size LARGE on phone.
Here's the tablet view

[Chandra-Sekhar-Bala]

@Chandra-Sekhar-Bala The padding attribute is global as we are using a wrap_content and got rid of setting a max_width, hence the button behavior

So do you prefer adding padding attribute to the style?

[Chandra-Sekhar-Bala]

I've added padding attribute which tends to solve this one I guess
Here's an example, when padding is enabled with text size as Medium and Extra large.

Medium:

Extra Large:

Looking forward to know your opinion about this @Ryggs @BenHenning !

[BenHenning]

I haven't been as involved with the nature of this particular issue or the different solutions considered. @rt4914 since you have more context, could you share your thoughts on the ongoing discussion here?

[rt4914]

@Chandra-Sekhar-Bala Yes adding padding is a better way to solve this. Basically follow these guidelines:

• Avoid giving fixed width/height
• Add padding to all sides of text -- inside button
• Use sp for textsize and dp for everything else.

These guidelines should be sufficient to solve this issue.

[Chandra-Sekhar-Bala]

@rt4914 Got it, thanks. I will make a PR :-)