Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuestionAssessmentProgressControllerTest regressed #3960

Closed
BenHenning opened this issue Oct 21, 2021 · 0 comments · Fixed by #3966
Closed

QuestionAssessmentProgressControllerTest regressed #3960

BenHenning opened this issue Oct 21, 2021 · 0 comments · Fixed by #3966
Assignees
@BenHenning
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Per a conversation with @TheRealJessicaLi it seems #3796 regressed some tests in QuestionAssessmentProgressControllerTest due to unnoticed changes to some of the json files. See #3796 (comment) for context.

Per Jessica, it seems that one of the misconception IDs was broken in questions.json:

https://github.com/oppia/oppia-android/pull/3796/files#diff-efbbbdd764162227307060a4dcad5448658c59951aca70907556967243e667a6L1722

I checked all the others and this seems like the only one that regressed. It's not clear to me why it regressed, but it's an easy fix, and hopefully it addresses the issue around the unexpected logical changes to some of the QuestionAssessmentProgressControllerTest tests.
@BenHenning BenHenning self-assigned this Oct 21, 2021
@BenHenning BenHenning mentioned this issue Oct 22, 2021
Merged
6 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3960: Fix regressed questions tests oppia/oppia-android
1 participant
@BenHenning