Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all language enums to OppiaLanguage #3793

Open
BenHenning opened this issue Sep 15, 2021 · 0 comments
Open

Consolidate all language enums to OppiaLanguage #3793

BenHenning opened this issue Sep 15, 2021 · 0 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Sep 15, 2021 •
edited
Loading

This is pertaining to unreleased localization code that will go into review shortly.

A new OppiaLanguage proto is being introduced that's backed by an actual language configuration file. There are two existing proto enums (AppLanguage & AudioLanguage) in profile.proto and that should be consolidated with the new OppiaLanguage proto. Further, all other references to direct languages (like "English" such as in OptionsControlViewModel) should be isolated to the locale or translation domain/utility subpackages, not hardcoded anywhere since these are contexts that are very likely dependent on the current selected locale.

Related issue: #669 except we don't actually need to fetch the list from the backend anymore given the local configuration file.
@rishidyno rishidyno self-assigned this Feb 22, 2022
@rishidyno rishidyno removed their assignment May 26, 2022
@BenHenning BenHenning added this to the Beta MR2 milestone Jun 11, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added issue_user_developer Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 16, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
5 participants
@seanlip @BenHenning @MohitGupta121 @rishidyno @Broppia