Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Onboarding Images in Landscape mode #3655

Closed
rt4914 opened this issue Aug 7, 2021 · 1 comment
Closed

RTL Onboarding Images in Landscape mode #3655

rt4914 opened this issue Aug 7, 2021 · 1 comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: High It's not clear what the solution is. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 7, 2021

PR Reference: #3635

Screenshot LTR and RTL

Mobile Portrait:

Screenshot_1627853193..... Screenshot_1627853346
Screenshot_1627853198.....Screenshot_1627853351

Screenshot_1627853201.....Screenshot_1627853355

Screenshot_1627853205.......Screenshot_1627853359

Mobile Landscape:

Screenshot_1627853246......Screenshot_1627853385

Screenshot_1627853243........Screenshot_1627853381
Screenshot_1627853239.......Screenshot_1627853376

Screenshot_1627853228....Screenshot_1627853368

Tablet Portrait:
Screenshot_1627853506......Screenshot_1627853600
Screenshot_1627853510....Screenshot_1627853598
Screenshot_1627853513....Screenshot_1627853595
Screenshot_1627853519.....Screenshot_1627853590

Tablet Landscape:
Screenshot_1627853539....Screenshot_1627853572
Screenshot_1627853535....Screenshot_1627853575
Screenshot_1627853531.....Screenshot_1627853579
Screenshot_1627853526.....Screenshot_1627853582

In all of above images notice how in RTL portrait the foreground is flipped. It found nice if only the background is flipped and not the foreground. Currently this is not possible because the foreground + background is part of a single image. Also if we create new images with flipped background for RTL then the apk size would increase because of these new images which is not great.

So we need to find a solution such that:

  1. background is flipped for RTL
  2. foreground remains the same in LTR and RTL
  3. apk size does not increase at all.

Possible Theoretical Solution
(Note: This is just a theory and haven't been tested at all.)

  1. Let's take one of these images and assume that its size is 4KB. This 4KB image comprise of foreground as well as background.
  2. Now if we can create separate image for foreground and separate image for background such that each of these takes approx 2 KB each and combined it takes 4 KB. In this case we can again achieve our original image by overall these images on top of each other in UI and still the apk size will remain same. (This theory that on creating separating images and total of those two images will be equal to that of the original has not been tested.)
  3. If above step us possible then now in RTL we can just flip the background and keep the foreground as it is and our apk size will also remain the same.

This issue does require some design expertise and also if the apk size changes even slightly then this issue will get closed.

@rt4914 rt4914 added this to the Backlog milestone Aug 7, 2021
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_enhancement Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 15, 2022
@BenHenning BenHenning removed this from the Backlog milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added the Work: High It's not clear what the solution is. label Jul 9, 2023
@adhiamboperes
Copy link
Collaborator

Closing since the onboarding layout design has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: High It's not clear what the solution is. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

5 participants