-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge profile_chooser_add_view.xml into single xml file #3556
Comments
can u pl assign this to me and pl guide how to setup . |
@rt4914 Can you please assign me this issue? |
@ArchitJain1201 Assigning you this issue |
@bkaur-bkj @rt4914 Can you please suggest how can I proceed further on this issue as
|
@rt4914 I checked out this issue but it has a lot of differences in mobile/layout as well as mobile/landscape too, even the orientation and layout components differ. PTAL |
yeah, that's correct. Closing this as this cannot be merged. |
Currently there are 4 versions of
profile_chooser_add_view.xml
file merge it into single xml file.We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in
dimens.xml
file and use it accordingly.Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
The text was updated successfully, but these errors were encountered: