Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge profile_chooser_add_view.xml into single xml file #3556

Closed
rt4914 opened this issue Jul 27, 2021 · 6 comments
Closed

Merge profile_chooser_add_view.xml into single xml file #3556

rt4914 opened this issue Jul 27, 2021 · 6 comments
Assignees
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 27, 2021

Currently there are 4 versions of profile_chooser_add_view.xml file merge it into single xml file.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.

@rt4914 rt4914 added this to the Backlog milestone Jul 27, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Type: Improvement labels Jul 27, 2021
@shubhanshu-coder
Copy link

can u pl assign this to me and pl guide how to setup .

@ArchitJain1201
Copy link
Contributor

@rt4914 Can you please assign me this issue?

@rt4914
Copy link
Contributor Author

rt4914 commented Jan 19, 2022

@ArchitJain1201 Assigning you this issue

@ArchitJain1201
Copy link
Contributor

ArchitJain1201 commented Jan 28, 2022

@bkaur-bkj @rt4914 Can you please suggest how can I proceed further on this issue as

  1. layout\profile_chooser_add_view.xml has a different UI layout than the other three
  2. layout-sw600dp-port/profile_chooser_add_view.xml and layout-sw600dp-land/profile_chooser_add_view.xml uses a different variable for paddingEnd and paddingStart, and can't merge the variable into one as they have different functionality and are used in other places also. ( as shown in the screenshot )

image

**for profile_chooser_description_margin_end_profile_not_added**

image

**for profile_chooser_add_view_parent_margin_start_profile_not_added**

image

@bkaur-bkj
Copy link
Contributor

@rt4914 I checked out this issue but it has a lot of differences in mobile/layout as well as mobile/landscape too, even the orientation and layout components differ. PTAL

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 1, 2022

yeah, that's correct. Closing this as this cannot be merged.

@rt4914 rt4914 closed this as completed Feb 1, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Development

No branches or pull requests

6 participants