Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Language preferences reset upon changing the display orientation #3008

Closed
Karanjot-singh opened this issue Mar 25, 2021 · 7 comments
Closed
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Karanjot-singh
Copy link
Contributor

Karanjot-singh commented Mar 25, 2021

Describe the bug
Language preferences for audio are reset to English on changing the display orientation from portrait to landscape and vice-versa

To Reproduce
Steps to reproduce the behaviour:

  1. Go to 'Topic: Fractions'
  2. Click on 'Lessons'
  3. Head to "Mathew Goes to the bakery"
  4. Enable audio from the top and select "Hindi" or "Hinglish"
  5. Rotate the device
  6. Play the audio again to observe the bug

Expected behavior
The audio language preference should remain the same during the lesson irrespective of the device orientation

Screenshots
If applicable, add screenshots or videos to help explain your problem.

Please enable audio for the video below

language-preference.mp4

Device
Oneplus6
SDK Version 29

Additional context
Add any other context about the problem here.

@Karanjot-singh
Copy link
Contributor Author

@rt4914 Could you please verify if this issue is not duplicate?

@jonathanalvares9009
Copy link
Contributor

Can I work on this issue?

@jonathanalvares9009
Copy link
Contributor

@Karanjot-singh this bug only resets the audio to the start. It doesn't change the language. I have tested it on an emulator and also on a physical device.

@imraghav20
Copy link
Contributor

@FareesHussain I guess this issue can be solved in #2557 itself.

Currently, this function is executed again on screen rotation and language settings are changed.

On using onSavedInstance method as being used in #2557 we can try saving the selected language.

@FareesHussain
Copy link
Contributor

@FareesHussain I guess this issue can be solved in #2557 itself.

Currently, this function is executed again on screen rotation and language settings are changed.

On using onSavedInstance method as being used in #2557 we can try saving the selected language.

@imraghav20 Thanks for the update, if possible I would like other contributors to work on this once it is merged.
and yes this issue will be blocked on #2557 in that case.

@imraghav20
Copy link
Contributor

@FareesHussain I guess this issue can be solved in #2557 itself.
Currently, this function is executed again on screen rotation and language settings are changed.
On using onSavedInstance method as being used in #2557 we can try saving the selected language.

@imraghav20 Thanks for the update, if possible I would like other contributors to work on this once it is merged.
and yes this issue will be blocked on #2557 in that case.

Sure @FareesHussain . Even I would love to take up this issue once your PR is merged.

@rt4914
Copy link
Contributor

rt4914 commented Jul 11, 2021

Closing this as it will get covered as part of #2514 and #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

6 participants