Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImageRegionSelectionInteractionViewTest for Robolectric #1965

Closed
Sarthak2601 opened this issue Oct 9, 2020 · 7 comments
Closed

Fix ImageRegionSelectionInteractionViewTest for Robolectric #1965

Sarthak2601 opened this issue Oct 9, 2020 · 7 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Currently, the ImageRegionSelectionInteractionViewTest are passing on Espresso but they should also pass on Robolectric. Fix these below mentioned files to make sure that the tests pass on Robolectric.

You can run robolectric tests by following these steps: https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#running-roboelectric-tests

Fixing test cases will need to introduce TextApplicationComponent. This can be seen here.

@Sarthak2601 Sarthak2601 added Priority: Essential This work item must be completed for its milestone. SLoP 2020 labels Oct 9, 2020
@Sarthak2601 Sarthak2601 added this to the Beta milestone Oct 9, 2020
@aggarwalpulkit596
Copy link
Contributor

This would be a bit too much for slop as it requires changes into roboelectric framework

@Sarthak2601
Copy link
Contributor Author

Sarthak2601 commented Oct 9, 2020

This would be a bit too much for slop as it requires changes into roboelectric framework

This issue was already present for SLoP under #1869. However I think @aggarwalpulkit596 is right here.
@BenHenning @rt4914 thoughts?

@rt4914
Copy link
Contributor

rt4914 commented Oct 9, 2020

This would be a bit too much for slop as it requires changes into roboelectric framework

This issue was already present for SLoP under #1869. However I think @aggarwalpulkit596 is right here.
@BenHenning @rt4914 thoughts?

@Sarthak2601 I agree with you. Let's remove this from SLoP, considering we already have good number of issues.

@anandwana001
Copy link
Contributor

@rt4914 @aggarwalpulkit596 This issue is Duplicate for #1611

@rt4914
Copy link
Contributor

rt4914 commented Nov 8, 2020

@rt4914 @aggarwalpulkit596 This issue is Duplicate for #1611

@anandwana001 I not fully sure here.

@anandwana001
Copy link
Contributor

@rt4914 @aggarwalpulkit596 This issue is Duplicate for #1611

@anandwana001 I not fully sure here.

@rt4914 All the test case are marked with #1611 issue only

@rt4914
Copy link
Contributor

rt4914 commented Nov 10, 2020

Duplicate. #1611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

5 participants