From 75709409bfd498432b19b16b2471c895b4f53051 Mon Sep 17 00:00:00 2001
From: Akash Koradia <akashkoradia1@gmail.com>
Date: Fri, 17 Jan 2020 23:32:34 +0530
Subject: [PATCH] Fix part of #10: Hifi ContinuePlaying (#605)

* Removed padding from sides in Image in ongoing_story_card in ContinuePlayingList.

* Reapplied side padding to the image. Removed hardcoded height attribute and applied dimensionRatio to the image.

* ContentDescription attribute and the string reference for it is added in ongoing_story_card.

* ScaleType of ImageView is changed and side paddings are removed, RecyclerView paddingBottom set to 172dp

* Removed padding top from the image in ongoing_story_card.
---
 app/src/main/res/layout/continue_playing_fragment.xml |  2 +-
 app/src/main/res/layout/ongoing_story_card.xml        | 10 ++++------
 app/src/main/res/values/strings.xml                   |  1 +
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/app/src/main/res/layout/continue_playing_fragment.xml b/app/src/main/res/layout/continue_playing_fragment.xml
index 1d0c4432b07..213b0eac59e 100644
--- a/app/src/main/res/layout/continue_playing_fragment.xml
+++ b/app/src/main/res/layout/continue_playing_fragment.xml
@@ -45,7 +45,7 @@
         android:clipToPadding="false"
         android:overScrollMode="never"
         android:paddingTop="8dp"
-        android:paddingBottom="128dp"
+        android:paddingBottom="172dp"
         android:scrollbars="none"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" />
 
diff --git a/app/src/main/res/layout/ongoing_story_card.xml b/app/src/main/res/layout/ongoing_story_card.xml
index dd14dea5114..ffadcb727b2 100755
--- a/app/src/main/res/layout/ongoing_story_card.xml
+++ b/app/src/main/res/layout/ongoing_story_card.xml
@@ -29,15 +29,13 @@
       <ImageView
         android:id="@+id/lesson_thumbnail"
         android:layout_width="80dp"
-        android:layout_height="44dp"
+        android:layout_height="0dp"
         android:layout_marginStart="8dp"
-        android:importantForAccessibility="no"
-        android:paddingStart="40dp"
-        android:paddingTop="4dp"
-        android:paddingEnd="40dp"
-        android:scaleType="centerCrop"
+        android:contentDescription="@{@string/lesson_thumbnail_content_description(viewModel.ongoingStory.nextChapterName)}"
+        android:scaleType="centerInside"
         android:src="@{viewModel.ongoingStory.lessonThumbnail.thumbnailGraphic}"
         app:layout_constraintBottom_toBottomOf="parent"
+        app:layout_constraintDimensionRatio="16:9"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
         app:roundedRectDrawableWithColor="@{viewModel.ongoingStory.lessonThumbnail.backgroundColorRgb}" />
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index da9713ebe06..bb7e71d40b8 100755
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -60,6 +60,7 @@
   <string name="view_all">View All</string>
   <string name="ongoing_story_last_week">Played within the Last Week</string>
   <string name="ongoing_story_last_month">Played within the Last Month</string>
+  <string name="lesson_thumbnail_content_description">Image for %s</string>
   <string name="all_topics">All Topics</string>
   <string name="stories_you_can_play">Stories You Can Play</string>
   <string name="go_to_previous_page">Go to previous page.</string>