From 2d60ca52c2c049e69d7270a00049eb755650f5ef Mon Sep 17 00:00:00 2001 From: Sean Lip Date: Mon, 5 Jun 2023 17:51:46 +0800 Subject: [PATCH] Fix #3886 and #3887: drop remaining KitKat TODOs. --- build_flavors.bzl | 2 +- .../org/oppia/android/util/parser/image/GlideImageLoader.kt | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/build_flavors.bzl b/build_flavors.bzl index e141ba1e702..9052490bf85 100644 --- a/build_flavors.bzl +++ b/build_flavors.bzl @@ -92,7 +92,7 @@ _FLAVOR_METADATA = { "target_sdk_version": 31, "multidex": "manual_main_dex", "main_dex_list": _MAIN_DEX_LIST_TARGET_KITKAT, - "proguard_specs": [], # TODO(#3886): Re-add Proguard support to alpha_kitkat. + "proguard_specs": [], "production_release": True, "deps": [ "//app/src/main/java/org/oppia/android/app/application/alpha:alpha_application", diff --git a/utility/src/main/java/org/oppia/android/util/parser/image/GlideImageLoader.kt b/utility/src/main/java/org/oppia/android/util/parser/image/GlideImageLoader.kt index 92002d17fb2..7fd1cfa7f1f 100644 --- a/utility/src/main/java/org/oppia/android/util/parser/image/GlideImageLoader.kt +++ b/utility/src/main/java/org/oppia/android/util/parser/image/GlideImageLoader.kt @@ -65,7 +65,6 @@ class GlideImageLoader @Inject constructor( target: ImageTarget, transformations: List ) { - // TODO(#3887): Investigate why this has a native crash on KitKat & find a fix. glide .asDrawable() .load(imageDrawableResId)