From 2c3784e9d09acdf4af07809c65276f2bf7381053 Mon Sep 17 00:00:00 2001
From: Anton Magnusson <44293537+antonmagnus@users.noreply.github.com>
Date: Wed, 11 Jan 2023 01:28:46 +0100
Subject: [PATCH] Fix #4722: Created date not fully visible for certain devices
 and languages (#4755)

## Explanation
Fixes issue #4772

This PR adds some margin to the end of the created date text on the edit
profile view to make sure that it's fully visible.

The main development was done on a pixel 3a on API 29 (see the
screenshots below). However, since the issue was reported on a Infinix
SMART 5 the changes have also been tested on a device with a similar
screen resolution (Galaxy Nexus on API 29).

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
### Previous version

![oppia_old_version_port](https://user-images.githubusercontent.com/44293537/203513709-70aae1c8-306a-43a0-ade3-6371dcc2d693.png)

### New version

![oppia_port](https://user-images.githubusercontent.com/44293537/203330112-35de7db9-36b7-4006-8863-b4bf5ad7ff43.png)


![oppia_port_land](https://user-images.githubusercontent.com/44293537/203330075-ba7448f0-df05-4822-8213-6dcc11469a22.png)


![oppia_eng](https://user-images.githubusercontent.com/44293537/203330137-a94de023-f132-48c7-9cbf-dbd6d1f7c10d.png)


![oppia_arabic](https://user-images.githubusercontent.com/44293537/203332868-f521a718-e49a-44c9-8f2c-6cb8e0495032.png)

### ProfileEditFragmentTest
<img width="1680" alt="Screenshot 2022-11-23 at 10 29 42"
src="https://user-images.githubusercontent.com/44293537/203513658-2245dba9-daf7-47f2-93e3-2ff9c66c9658.png">

Co-authored-by: Ben Henning <ben@oppia.org>
---
 app/src/main/res/layout/profile_edit_fragment.xml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/src/main/res/layout/profile_edit_fragment.xml b/app/src/main/res/layout/profile_edit_fragment.xml
index e93d2d02af6..b1e0f7fdc10 100644
--- a/app/src/main/res/layout/profile_edit_fragment.xml
+++ b/app/src/main/res/layout/profile_edit_fragment.xml
@@ -65,10 +65,12 @@
       <TextView
         android:id="@+id/profile_edit_created"
         style="@style/Subtitle2"
-        android:layout_width="wrap_content"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
+        android:layout_marginEnd="8dp"
         android:textColor="@color/component_color_shared_secondary_1_text_color"
         app:layout_constraintBottom_toBottomOf="@+id/profile_edit_image"
+        app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="@+id/profile_edit_name"
         app:layout_constraintTop_toBottomOf="@+id/profile_edit_name"
         app:layout_constraintVertical_chainStyle="packed"