From 1bb1ffa97b2c14e002fa0371991f4f25351a79cd Mon Sep 17 00:00:00 2001 From: Rajat Talesra Date: Mon, 17 Aug 2020 13:01:24 +0530 Subject: [PATCH] Fixes part of #40 & #42: Generalisation Highfi Mobile Portrait + Landscape - Buttons (#1653) * Continue/ Previous button margins * Next button margins added * Submit button margin added * Removed start/end margin from error * Reply button margins * Topic button margin top changed * Nit fix * Bottom padding added * Question Progress * Changed congratulations margins * Updated drag and drop margins Co-authored-by: Rajat Talesra --- .../layout-land/continue_interaction_item.xml | 32 ++++++++-- .../continue_navigation_button_item.xml | 44 +++++++++---- .../drag_drop_interaction_item.xml | 10 ++- .../layout-land/fraction_interaction_item.xml | 2 - .../main/res/layout-land/next_button_item.xml | 36 ++++++++--- .../numeric_input_interaction_item.xml | 2 - .../res/layout-land/previous_button_item.xml | 34 +++++++--- .../layout-land/question_player_fragment.xml | 18 +++--- .../res/layout-land/replay_button_item.xml | 11 ++-- .../return_to_topic_button_item.xml | 34 +++++++--- .../main/res/layout-land/state_fragment.xml | 6 +- .../res/layout-land/submit_button_item.xml | 34 +++++++--- .../continue_interaction_item.xml | 50 ++++++--------- .../continue_navigation_button_item.xml | 60 +++++++----------- .../drag_drop_interaction_item.xml | 9 ++- .../fraction_interaction_item.xml | 2 - .../layout-sw600dp-land/next_button_item.xml | 51 ++++++--------- .../numeric_input_interaction_item.xml | 2 - .../previous_button_item.xml | 49 +++++---------- .../question_player_fragment.xml | 4 ++ .../replay_button_item.xml | 48 +++----------- .../return_to_topic_button_item.xml | 54 ++++++---------- .../submit_button_item.xml | 52 ++++++--------- .../continue_interaction_item.xml | 50 ++++++--------- .../continue_navigation_button_item.xml | 60 +++++++----------- .../drag_drop_interaction_item.xml | 9 ++- .../fraction_interaction_item.xml | 4 +- .../layout-sw600dp-port/next_button_item.xml | 51 ++++++--------- .../numeric_input_interaction_item.xml | 2 - .../previous_button_item.xml | 49 +++++---------- .../question_player_fragment.xml | 4 ++ .../replay_button_item.xml | 48 +++----------- .../return_to_topic_button_item.xml | 54 ++++++---------- .../submit_button_item.xml | 52 ++++++--------- .../res/layout/continue_interaction_item.xml | 52 ++++++--------- .../continue_navigation_button_item.xml | 63 +++++++------------ .../res/layout/drag_drop_interaction_item.xml | 12 ++-- .../res/layout/fraction_interaction_item.xml | 2 - app/src/main/res/layout/next_button_item.xml | 55 ++++++---------- .../layout/numeric_input_interaction_item.xml | 2 - .../main/res/layout/previous_button_item.xml | 53 ++++++---------- .../res/layout/question_player_fragment.xml | 8 ++- .../main/res/layout/replay_button_item.xml | 49 +++------------ .../layout/return_to_topic_button_item.xml | 59 +++++++---------- app/src/main/res/layout/state_fragment.xml | 6 +- .../main/res/layout/submit_button_item.xml | 55 ++++++---------- app/src/main/res/values/dimens.xml | 4 ++ 47 files changed, 614 insertions(+), 833 deletions(-) diff --git a/app/src/main/res/layout-land/continue_interaction_item.xml b/app/src/main/res/layout-land/continue_interaction_item.xml index 610821f3b5c..10930a91fcc 100644 --- a/app/src/main/res/layout-land/continue_interaction_item.xml +++ b/app/src/main/res/layout-land/continue_interaction_item.xml @@ -10,12 +10,35 @@ name="viewModel" type="org.oppia.app.player.state.itemviewmodel.ContinueInteractionViewModel" /> - + + + + + + + app:explorationSplitViewMarginApplicable="@{viewModel.hasConversationView && viewModel.isSplitView}" + app:explorationSplitViewMarginBottom="@{@dimen/margin_0}" + app:explorationSplitViewMarginEnd="@{@dimen/margin_60}" + app:explorationSplitViewMarginStart="@{@dimen/margin_20}" + app:explorationSplitViewMarginTop="@{@dimen/margin_72}" + app:explorationViewMarginApplicable="@{viewModel.hasConversationView && !viewModel.isSplitView}" + app:explorationViewMarginBottom="@{@dimen/margin_0}" + app:explorationViewMarginEnd="@{@dimen/margin_44}" + app:explorationViewMarginStart="@{@dimen/margin_44}" + app:explorationViewMarginTop="@{@dimen/margin_24}" + app:questionSplitViewMarginApplicable="@{!viewModel.hasConversationView && viewModel.isSplitView}" + app:questionSplitViewMarginBottom="@{@dimen/margin_0}" + app:questionSplitViewMarginEnd="@{@dimen/margin_60}" + app:questionSplitViewMarginStart="@{@dimen/margin_20}" + app:questionSplitViewMarginTop="@{@dimen/margin_72}" + app:questionViewMarginApplicable="@{!viewModel.hasConversationView && !viewModel.isSplitView}" + app:questionViewMarginBottom="@{@dimen/margin_0}" + app:questionViewMarginEnd="@{@dimen/margin_60}" + app:questionViewMarginStart="@{@dimen/margin_60}" + app:questionViewMarginTop="@{@dimen/margin_24}"> - + + + + + + + app:explorationSplitViewMarginApplicable="@{buttonViewModel.hasConversationView && buttonViewModel.isSplitView}" + app:explorationSplitViewMarginBottom="@{@dimen/margin_0}" + app:explorationSplitViewMarginEnd="@{@dimen/margin_60}" + app:explorationSplitViewMarginStart="@{@dimen/margin_20}" + app:explorationSplitViewMarginTop="@{@dimen/margin_72}" + app:explorationViewMarginApplicable="@{buttonViewModel.hasConversationView && !buttonViewModel.isSplitView}" + app:explorationViewMarginBottom="@{@dimen/margin_0}" + app:explorationViewMarginEnd="@{@dimen/margin_44}" + app:explorationViewMarginStart="@{@dimen/margin_44}" + app:explorationViewMarginTop="@{@dimen/margin_24}" + app:questionSplitViewMarginApplicable="@{!buttonViewModel.hasConversationView && buttonViewModel.isSplitView}" + app:questionSplitViewMarginBottom="@{@dimen/margin_0}" + app:questionSplitViewMarginEnd="@{@dimen/margin_60}" + app:questionSplitViewMarginStart="@{@dimen/margin_20}" + app:questionSplitViewMarginTop="@{@dimen/margin_72}" + app:questionViewMarginApplicable="@{!buttonViewModel.hasConversationView && !buttonViewModel.isSplitView}" + app:questionViewMarginBottom="@{@dimen/margin_0}" + app:questionViewMarginEnd="@{@dimen/margin_60}" + app:questionViewMarginStart="@{@dimen/margin_60}" + app:questionViewMarginTop="@{@dimen/margin_24}"> + app:layout_constraintTop_toTopOf="parent" />