Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www/caddy: Add support for the propagation_timeout and propagation_delay tls options #4161

Closed
Stitch10925 opened this issue Aug 6, 2024 · 4 comments · Fixed by #4170
Closed
Assignees
Labels
feature Adding new functionality

Comments

@Stitch10925
Copy link

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.
Receiving a wildcard certificate only worked once. When the time came for a renewal I would always get propagation check errors. Research brought me to these parameters which fixed the problem.

Describe the solution you'd like
Adding those two parameters to my Caddyfile fixed a problem I was having retrieving wildcard certificates for my domain.

Describe alternatives you've considered
There are none

Additional context
The Caddy team added the parameters because many people had issues with retrieving wildcard certificates.

Caddy forum post: caddytls: Add propagation_delay, support propagation_timeout -1

Documentation around the tls module and propagation parameters are here: tls docu

NOTE:

The current Caddyfile generated by the plugin creates levels: tls > dns
This will need to be changed to: tls > issuer acme > dns

The "issuer acme" level will need to be added for the propagation properties to be available. Structure is as follows:

*.example.com { tls { issuer acme { dns provider { api_key xxxxxxx ... } propagation_delay 30s propagation_timeout -1 } } ... }

@Monviech
Copy link
Member

Monviech commented Aug 7, 2024

Hey, do you want to try adding that? If not, I can do it, but it might take a while since Im busier now.

@Stitch10925
Copy link
Author

Sadly enough I'm not capable to do this myself, otherwise I would have gladly helped.

To me it's not that urgent. As long as I don't change my config now, the parameters will keep working.

@Monviech
Copy link
Member

@Stitch10925

Please test this patch with:

opnsense-patch -c plugins 64a3884

@Stitch10925
Copy link
Author

@Monviech
I found the flag and set it, then saved and applied. The properties are added correctly, the Caddyfile is valid, so I assume everything is ok. I cannot validate completely at the moment but I will be able to check the wildcard certificate retrieval soon.

Thanks for adding a patch for this issue so quickly, that was quite remarkable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

Successfully merging a pull request may close this issue.

2 participants