scripts/install_local.sh: upstream-operators.catalogsource.yaml not written correctly

[estroz]

make run-local fails on master

$ tmp=$(mktemp -d)
$ git clone https://github.com/operator-framework/operator-lifecycle-manager.git $tmp
$ pushd $tmp
$ make run-local
...
Successfully built 9934bcd7256b
mkdir -p build/resources
. ./scripts/package_release.sh 1.0.0 build/resources Documentation/install/local-values.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_00-namespace.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_10-olm-operators.configmap.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_02-clusterserviceversion.crd.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_03-installplan.crd.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_04-subscription.crd.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_05-catalogsource.crd.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_09-operatorgroup.crd.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_01-olm-operator.serviceaccount.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_08-aggregated.clusterrole.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_06-olm-operator.deployment.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_07-catalog-operator.deployment.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_11-olm-operators.catalogsource.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_17-upstream-operators.catalogsource.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_12-operatorgroup-default.yaml
wrote /tmp/tmp.NXnkeSQQvy/chart/olm/templates/0000_50_olm_13-packageserver.subscription.yaml
. ./scripts/install_local.sh local build/resources
namespace/local unchanged
namespace/local-operators unchanged
clusterrole.rbac.authorization.k8s.io/system:controller:operator-lifecycle-manager unchanged
serviceaccount/olm-operator-serviceaccount unchanged
clusterrolebinding.rbac.authorization.k8s.io/olm-operator-binding-local unchanged
customresourcedefinition.apiextensions.k8s.io/clusterserviceversions.operators.coreos.com configured
customresourcedefinition.apiextensions.k8s.io/installplans.operators.coreos.com unchanged
customresourcedefinition.apiextensions.k8s.io/subscriptions.operators.coreos.com unchanged
customresourcedefinition.apiextensions.k8s.io/catalogsources.operators.coreos.com unchanged
deployment.apps/olm-operator unchanged
deployment.apps/catalog-operator unchanged
clusterrole.rbac.authorization.k8s.io/aggregate-olm-edit unchanged
clusterrole.rbac.authorization.k8s.io/aggregate-olm-view unchanged
customresourcedefinition.apiextensions.k8s.io/operatorgroups.operators.coreos.com unchanged
configmap "olm-operators" deleted
configmap/olm-operators replaced
catalogsource.operators.coreos.com/olm-operators unchanged
operatorgroup.operators.coreos.com/global-operators unchanged
operatorgroup.operators.coreos.com/olm-operators unchanged
subscription.operators.coreos.com/packageserver unchanged
error: no objects passed to apply
make: *** [Makefile:55: run-local] Error 1

build/resources/0000_50_olm_17-upstream-operators.catalogsource.yaml is empty:

$ cat chart/olm/templates/0000_50_olm_17-upstream-operators.catalogsource.yaml
---
# Source: olm/templates/0000_50_olm_17-upstream-operators.catalogsource.yaml
#! validate-crd: ./deploy/chart/templates/05-catalogsource.crd.yaml
#! parse-kind: CatalogSource

[njhale]

@estroz Thanks for reporting this! #771 , which has a few changes to the templates just merged, and when I tried make run-local I did not encounter this issue. Could you pull master and try again?

[estroz]

Fixed on master, cheers.