🐛 When upgrading catalogd to a revision that uses HTTPS, content URLs of existing Catalog objects remain unchanged.

[joelanford]

I believe this is because of this check:

catalogd/pkg/controllers/core/catalog_controller.go

Lines 135 to 141 in b68cda4

	// if ResolvedSource is not nil, it indicates that this is not the first time we're
	// unpacking this catalog.
	if catalog.Status.ResolvedSource != nil {
	if !unpackAgain(catalog) {
	return ctrl.Result{}, nil
	}
	}

I think there are two things to fix:

1. We should not read our own status to assess state. The Catalog status is where we write state after reading from elsewhere. In this case, we should read the actual source of truth (the cache?) to see if we have something unpacked.
2. Even if we don't need to unpack again, that doesn't mean there is nothing to do. For this bug, the thing we are missing is updating the content URL now that we're serving it via https.

[joelanford]

Hmm. It seems there is no way for the LocalDir storage implementation to determine if what it has stored is actually up-to-date. Solving this problem may require a more invasive change.

[joelanford]

Pretty sure this was fixed by #424