Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on link close #2064

Closed
plorenz opened this issue May 28, 2024 · 0 comments · Fixed by #2065
Closed

Fix panic on link close #2064

plorenz opened this issue May 28, 2024 · 0 comments · Fixed by #2065
Assignees
@plorenz
Labels
fabric Issue is related to fabric level functionality panic describes a code panic router Issue relates to the router

Comments

@plorenz
Copy link
Member

plorenz commented May 28, 2024

Panic likely caused by link closing because payload channel is closed while ack channel is still being initialized.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1a62428]

goroutine 5241 [running]:
github.com/openziti/channel/v2.(*channelImpl).Close(0xc00269a540?)
        /home/plorenz/go/pkg/mod/github.com/openziti/channel/[email protected]/impl.go:214 +0xe8
github.com/openziti/ziti/router/xlink_transport.(*splitImpl).Close(0xc000efac60)
        /home/plorenz/work/nf/ziti/router/xlink_transport/xlink_split.go:108 +0x83
github.com/openziti/ziti/router/handler_link.(*closeHandler).HandleClose.func1.1()
        /home/plorenz/work/nf/ziti/router/handler_link/close.go:51 +0x24
created by github.com/openziti/ziti/router/handler_link.(*closeHandler).HandleClose.func1 in goroutine 2950
        /home/plorenz/work/nf/ziti/router/handler_link/close.go:50 +0x3b6
@plorenz plorenz added router Issue relates to the router fabric Issue is related to fabric level functionality panic describes a code panic labels May 28, 2024
@plorenz plorenz self-assigned this May 28, 2024
plorenz added a commit that referenced this issue May 28, 2024
@plorenz
Fix panic on link close. Fixes #2064
8240d15
@plorenz plorenz mentioned this issue May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plorenz plorenz

Labels
fabric Issue is related to fabric level functionality panic describes a code panic router Issue relates to the router
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix link close panic and add retry delay randomization openziti/ziti
1 participant
@plorenz