diff --git a/project/Project.scala b/project/Project.scala index ebca24c9256..0ee7b8c4434 100644 --- a/project/Project.scala +++ b/project/Project.scala @@ -87,9 +87,9 @@ object Zipkin extends Build { ) val CASSIE_VERSION = "0.22.0" - val FINAGLE_VERSION = "5.0.0" - val OSTRICH_VERSION = "8.0.1" - val UTIL_VERSION = "5.0.3" + val FINAGLE_VERSION = "5.1.0" + val OSTRICH_VERSION = "8.1.0" + val UTIL_VERSION = "5.2.0" lazy val common = Project( diff --git a/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraIndexConfig.scala b/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraIndexConfig.scala index 4e99c6079f0..34f4b2f535e 100644 --- a/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraIndexConfig.scala +++ b/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraIndexConfig.scala @@ -138,7 +138,7 @@ trait CassandraIndexConfig extends IndexConfig { log.info("Connected to Cassandra") new CassandraIndex() { val config = cassandraConfig - val keyspace = _keyspace + keyspace = _keyspace val serviceSpanNameIndex = _serviceSpanNameIndex val serviceNameIndex = _serviceNameIndex val annotationsIndex = _annotationsIndex diff --git a/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraStorageConfig.scala b/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraStorageConfig.scala index b997f76bb28..9ac4d0fbd8f 100644 --- a/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraStorageConfig.scala +++ b/zipkin-server/src/main/scala/com/twitter/zipkin/config/CassandraStorageConfig.scala @@ -49,7 +49,7 @@ trait CassandraStorageConfig extends StorageConfig { new CassandraStorage() { val cassandraConfig = _storageConfig.cassandraConfig val storageConfig = _storageConfig - val keyspace = _keyspace + keyspace = _keyspace val traces = _traces } } diff --git a/zipkin-server/src/main/scala/com/twitter/zipkin/query/ZipkinQuery.scala b/zipkin-server/src/main/scala/com/twitter/zipkin/query/ZipkinQuery.scala index 8987e0b9cb4..00465cff622 100644 --- a/zipkin-server/src/main/scala/com/twitter/zipkin/query/ZipkinQuery.scala +++ b/zipkin-server/src/main/scala/com/twitter/zipkin/query/ZipkinQuery.scala @@ -16,7 +16,6 @@ package com.twitter.zipkin.query * limitations under the License. * */ -import adjusters.Adjuster import com.twitter.logging.Logger import org.apache.thrift.protocol.TBinaryProtocol import com.twitter.zipkin.storage.{Index, Storage} diff --git a/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/Cassandra.scala b/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/Cassandra.scala index f9302ac5bae..0f9a086cb26 100644 --- a/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/Cassandra.scala +++ b/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/Cassandra.scala @@ -21,12 +21,13 @@ import com.twitter.logging.Logger trait Cassandra { val log = Logger.get - val keyspace: Keyspace + var keyspace: Keyspace = null def close() { if (keyspace != null) { log.info("Closing CassandraStorage connections") keyspace.close() + keyspace = null } } } diff --git a/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraIndex.scala b/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraIndex.scala index d7cf41a7e89..271d336c3e2 100644 --- a/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraIndex.scala +++ b/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraIndex.scala @@ -34,7 +34,6 @@ import com.twitter.zipkin.Constants trait CassandraIndex extends Index with Cassandra { val config: CassandraConfig - val keyspace: Keyspace /* Index `ColumnFamily`s */ val serviceSpanNameIndex : ColumnFamily[String, Long, Long] diff --git a/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraStorage.scala b/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraStorage.scala index 9690efee4af..d10019319e6 100644 --- a/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraStorage.scala +++ b/zipkin-server/src/main/scala/com/twitter/zipkin/storage/cassandra/CassandraStorage.scala @@ -32,8 +32,6 @@ trait CassandraStorage extends Storage with Cassandra { val storageConfig: CassandraStorageConfig - val keyspace: Keyspace - val traces: ColumnFamily[Long, String, gen.Span] // storing the span in the traces cf diff --git a/zipkin-server/src/test/scala/com/twitter/zipkin/storage/cassandra/CassandraIndexSpec.scala b/zipkin-server/src/test/scala/com/twitter/zipkin/storage/cassandra/CassandraIndexSpec.scala index d4666abde1c..7dd61a2e4fc 100644 --- a/zipkin-server/src/test/scala/com/twitter/zipkin/storage/cassandra/CassandraIndexSpec.scala +++ b/zipkin-server/src/test/scala/com/twitter/zipkin/storage/cassandra/CassandraIndexSpec.scala @@ -94,7 +94,6 @@ class CassandraIndexSpec extends Specification with JMocker with ClassMocker { val cs = new CassandraIndex() { val config = _config - val keyspace = null val serviceSpanNameIndex = null val serviceNameIndex = null val annotationsIndex = _annotationsIndex @@ -144,7 +143,6 @@ class CassandraIndexSpec extends Specification with JMocker with ClassMocker { val cass = new CassandraIndex() { val config = new CassandraConfig{} - val keyspace = null val serviceSpanNameIndex = null val serviceNameIndex = null val annotationsIndex = null @@ -174,7 +172,6 @@ class CassandraIndexSpec extends Specification with JMocker with ClassMocker { val cass = new CassandraIndex() { val config = new CassandraConfig{} - val keyspace = null val serviceSpanNameIndex = null val serviceNameIndex = null val annotationsIndex = null