Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gotjs intrumentation is not working #503

Open
vtapadia opened this issue May 20, 2020 · 3 comments
Open

gotjs intrumentation is not working #503

vtapadia opened this issue May 20, 2020 · 3 comments

Comments

@vtapadia
Copy link

While testing with gotjs instrumentation, I am running into issues.

import wrapGot from "zipkin-instrumentation-gotjs";
const gotAPI = wrapGot(got, {tracer, serviceName:config.serviceName , remoteServiceName:"my-service"});

the build works fine, but at runtime, I get the following error

const gotAPI = zipkin_instrumentation_gotjs_1.default(got_1
TypeError: zipkin_instrumentation_gotjs_1.default is not a function

Note: The documentation still refer the package as -got so maybe it is good to change that also.

@jcchavezs
Copy link
Contributor

Hi @vtapadia thanks for opening this issue. Is there a way you can fork https://github.com/openzipkin/zipkin-js-example and reproduce the error?

Thanks for the heads up with the doc issue.

@vtapadia
Copy link
Author

I am a novice in nodejs and have a sample project where I have been experimenting with this.
The project URL is
https://github.com/vtapadia/sample-node-app/tree/zipkin-tracing

The configuration of gotjs is done at src/lib/myService.ts file.

The build run fine but when I run the project, I see the error.
You can use the following command

npm run build && npm start

Do let me know if that helps, otherwise I will explore the examples also.

@jcchavezs
Copy link
Contributor

Any idea @tacigar @anuraaga ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants