Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proto generated files to github.com/golang/protobuf v1.4.2 or newer #164

Closed
bogdandrutu opened this issue Jul 28, 2020 · 3 comments · Fixed by #165
Closed

Update proto generated files to github.com/golang/protobuf v1.4.2 or newer #164

bogdandrutu opened this issue Jul 28, 2020 · 3 comments · Fixed by #165

Comments

@bogdandrutu
Copy link
Contributor

https://github.com/openzipkin/zipkin-go/tree/master/proto/v2 it is generated with a very old protobuf library (deprecated now). Would be good to update these files to the latest protobuf library.
@bogdandrutu
Copy link
Contributor Author

/cc @adriancole - we need help with this :)

@codefromthecrypt
Copy link
Member

just to spread things to folks who usually work in this area and might be able to knock out quicker.. cc @jcchavezs @basvanbeek any impact to do this (help wanted if you can)

@anuraaga anuraaga mentioned this issue Jul 28, 2020
Merged
@bogdandrutu
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update generated proto code to latest protoc anuraaga/zipkin-go
2 participants
@codefromthecrypt @bogdandrutu