-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enabled property to disable auto-loading #32
Comments
@adriancole we have a generic facility for disabling specific auto-loaded tracers in LoadService, but it requires passing in a flag or java system properties, so it might not be what you want. Sorry for the delay in getting back to you, was on vacation for the past couple weeks. |
Thanks @mosesn @adriancole! Yes, that's a good option. But now that I think about it again, if I'm gonna pass a flag anyway, I might as well just use flag to define zipkin host! |
It's not clear from the README that providing your own The |
there's been a couple hints that we could make it possible to disable auto-loading of tracers. I'm not sure if that would be possible with code change here or not
linkerd/linkerd-zipkin#4 (comment) w/ @klingerf
and also a similar request recently on gitter by @komsit37 who is manually registering an http tracer and doesn't want a default one to pop up.
cc @mosesn for insight if we should add an "enabled" flag or if there are other things related to look at
The text was updated successfully, but these errors were encountered: