-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for async spans? #67
Comments
Thanks for asking, Sunil.
We are likely to pull out zipkin-go which could include the "flush"
operator on span present in Brave (which makes this work). It is possible
some custom hooks could be done in the mean time to accomplish the same.
On zipkin-go: there's currently no tracking issue for this, but it is
dependent on the "simplejson" effort: The simplified data structure has
been piloted in Brave 4+ as the primary span api, and that's been
successful. When we extract zipkin-go, we'd not only want the same
approach, but also a direct mapping to the model to make mapping less
indirect: openzipkin/zipkin#1644
|
PS the async as described in brave is SPSC or really one-way RPC. Multiple consumers are being elaborated here openzipkin/zipkin#1654 |
Closing this due to age and this repo only working with Zipkin v1 API. The native Zipkin Go lib will need to support async spans and by that I mean it will not only need to make it possible but also test that it is guaranteed to work given a documented procedure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One way async span is supported in brave - openzipkin/zipkin#1243
Are there plans to support this any time soon?
The text was updated successfully, but these errors were encountered: