-
Notifications
You must be signed in to change notification settings - Fork 25
When the zipkin host isn't localhost.. #25
Comments
looking at the code, it seems there are some constants relating to the fully-qualified api host. is there a way to use a relative path instead? (forgive me, if I misunderstand them) |
I am in the same boat , How can I have the localhost replaced with the relative path |
this is just waiting on work to do it. does anyone have time to help? |
What's the general idea for configuring this UI? I see that docker-zipkin uses a nginx to proxy the actual backend onto the same server that hosts the UI, and ZipkinService hardcodes 'localhost' and the port here: https://github.com/openzipkin/zipkin-ui/blob/master/src/app/zipkin/zipkin.ts#L155 Seems that one needs to do two things: kill the port reference there, and then fix all places that work with localhost? |
@ankon so when in development (and also many sites), the port is 9411. So, I supposed some means of configuring the api endpoint ex (http://localhost:9411) would be what's needed. Then, whatever parameter is needed would be passed to the deployment. One idea is to expose the api endpoint as a part of config.json, which is how the old UI gets its config, lacking that assume http://localhost:9411. There is a chicken/egg problem, of course as config.json is served by the host listening on 9411! TL;DR; I don't know the best way, but what you've mentioned makes sense. cc @openzipkin/devops-tooling |
@charlescui made a suggestion here openzipkin-attic/docker-zipkin#134 (comment) |
here's an example implementation #34 I think others should comment wrt the configuration approach. |
#34 suggests separate env variables to assign this.. like |
from @dragontree101
my zipkin-server is 1.16 and change zipkin-ui in 0.0.1
i use new zipkin-ui, but has error, i need change some ui-config?
i use config is
i think to change localhost to zipkin-server's ip? i am not deploy zipkin-server in my local.
The text was updated successfully, but these errors were encountered: