Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all dependencies #202

Open
benoit74 opened this issue Aug 18, 2023 · 3 comments
Open

Upgrade all dependencies #202

benoit74 opened this issue Aug 18, 2023 · 3 comments
Milestone

Comments

@benoit74
Copy link
Collaborator

Upgrade Python + JS + CSS dependencies to latest versions

@benoit74 benoit74 added this to the 2.2.0 milestone Aug 18, 2023
@benoit74 benoit74 mentioned this issue Aug 18, 2023
17 tasks
@Siddu24294
Copy link

Siddu24294 commented Mar 9, 2024

I would like to work on this..
I believe the way to go about this is:

  1. update the .toml file to update the dependencies written.
  2. Check if any changes are to be done in hatchback and tasks python files related to the updated modules.
  3. Run tests to check if it works
  4. submit the PR.

The only I Have is whether i have to upgrade dependencies to their latest version or to a specific version?
If to a specific version then which version?

@benoit74
Copy link
Collaborator Author

@Siddu24294 this is the way to go.

With one minor drawback you need to be aware of: there is no automated tests, so you will have to run the scrapper manually and confirm it still works as intended by going through the ZIM. And comparing it with another ZIM you would have built before the update.

I suggest that you start with it: run the scrapper with current codebase and understand how it works and what it the ZIM current behavior (we have some known bugs, including very visible ones like #219)

@Siddu24294
Copy link

Thanks for the guidance, I will get to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants