[WIP] General Protection Fault: snajpa's playground #16706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by protecting against sb->s_shrink eviction on umount with newer kernels deactivate_locked_super calls shrinker_free and only then sops->kill_sb cb, resulting in UAF on umount when trying to reach for the shrinker functions in zpl_prune_sb of in-umount dataset Signed-off-by: Pavel Snajdr <[email protected]>
Commit message TODO Signed-off-by: Pavel Snajdr <[email protected]>
Signed-off-by: Pavel Snajdr <[email protected]>
Other linux fs implementations seem to hold a reference to some buffer which seems to cause the inode to stay in place in tight memory conditions. Replicate such behavior. Signed-off-by: Pavel Snajdr <[email protected]>
|
Just a note that you may ensure that github actions are active on your fork (it's activated in project's settings), then you'll have the same CI runs in your fork too. |
|
@gmelikov thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I've been stuck for more than a month with #16608 trying different approaches to hunt down the problem, but I keep breaking other stuff, so I need to employ the testbots to help me throughout the journey. I could theoretically set up my own playground but I'd eventually also need the variety of kernels the bots provide already and that seems like a ton of work I don't currently have the time to do.
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.