Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenZFS Block Clonning Extension ... #15573

Open
vermaden opened this issue Nov 24, 2023 · 6 comments
Open

OpenZFS Block Clonning Extension ... #15573

vermaden opened this issue Nov 24, 2023 · 6 comments
Labels
Type: Feature Feature request or new feature

Comments

@vermaden
Copy link

IMHO the new OpenZFS Block Cloning feature could/should be extended to 'link' blocks that already are 'the same' (verified by checksum) making it offline deduplication solution based on and happening during scrub scan.

Of course its easier said then done - but hey - isn't that is the way how many feature ideas/improvements are done? :)

Regards,
vermaden

@vermaden vermaden added the Type: Feature Feature request or new feature label Nov 24, 2023
@Majiir
Copy link

Majiir commented Nov 28, 2023

Offline deduplication tools exist. As block cloning matures in ZFS, more existing tools will be able to utilize block cloning. For example, #15393 will make duperemove "just work". We don't necessarily need a ZFS feature for it.

In principle, a tool built for ZFS could identify potential duplicates more efficiently by comparing the checksums stored in metadata rather than rehashing all of the data. This would require various properties to match, like checksum algorithm, compression, record size, encryption keys, etc. This kind of approach trades off speed with deduplication efficiency. bedup is a similar tool for Btrfs.

Note that there are existing discussions in issues like #405 and #13349. With all of that in mind, I suggest that you take some time to do some research and then sharpen this issue by stating more precisely the feature you want to see. In particular, the issue title is too vague.

@vermaden
Copy link
Author

Hi and thank You for reply.

I suggest that you take some time to do some research and
then sharpen this issue by stating more precisely the feature
you want to see. In particular, the issue title is too vague.

If making 'offline deduplication' doing scrub using new Block Cloning feature is not obvious and precise enough - then I am too retarded to make feature requests here ...

Regards,
vermaden

@Majiir
Copy link

Majiir commented Nov 29, 2023

You're good 😄 Looks like I'm the one who misread it or got this mixed up with another issue. The title could be improved but the request makes sense.

@vermaden
Copy link
Author

vermaden commented Nov 29, 2023

Thanks, I am sorry to sound like an asshole here - its the LAST thing I want.

I just did not know how to phrase and describe that in other words - yes my English is not close to native level - the Slavic Polish soul takes its ground :>

@FL140
Copy link

FL140 commented Nov 29, 2023

You're good 😄 Looks like I'm the one who misread it or got this mixed up with another issue. The title could be improved but the request makes sense.

Well I think we are all a bit fast on the fence for the last two weeks when we see new issues which have the trigger phrase "block cloning" in the title, or is it just me? ;-)

@vermaden Apart from the fact that "Clonning" is a typo and should renamed to "Cloning" for search reasons, I may suggest something like "Implement deduplication during scrub based on block cloning feature." This would make your intention more clear.

@no-usernames-left
Copy link

"block cloning"

Oh no, not this again. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Feature request or new feature
Projects
None yet
Development

No branches or pull requests

4 participants