Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit test] improve unit test coverage for yurthub #917

Closed
rambohe-ch opened this issue Jul 18, 2022 · 3 comments · Fixed by #972
Closed

[unit test] improve unit test coverage for yurthub #917

rambohe-ch opened this issue Jul 18, 2022 · 3 comments · Fixed by #972
Assignees
Labels
kind/feature kind/feature

Comments

@rambohe-ch
Copy link
Member

rambohe-ch commented Jul 18, 2022

What would you like to be added:
improve unit test coverage for yurthub:

Why is this needed:
improve unit test coverage for OpenYurt project.

others
/kind feature

@rambohe-ch rambohe-ch added the kind/feature kind/feature label Jul 18, 2022
@Congrool
Copy link
Member

Since we're pending at #882 which has great changes on yurthub cache components, could we write unit tests after #882 being merged? Otherwise we have to rewrite these tests later.

Also, we'd better do #857 based on #882, otherwise we have to retest it later.

@rambohe-ch
Copy link
Member Author

Since we're pending at #882 which has great changes on yurthub cache components, could we write unit tests after #882 being merged? Otherwise we have to rewrite these tests later.

Also, we'd better do #857 based on #882, otherwise we have to retest it later.

@Congrool ok, i will focus on reviewing #882 and merge this pull request before unit test.

@donychen1134
Copy link
Contributor

/assign donychen1134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants