Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Should yurt-controller-manager deploy as Daemonset or static pod on control plane? #845

Closed
DrmagicE opened this issue May 24, 2022 · 2 comments
Labels
kind/question kind/question

Comments

@DrmagicE
Copy link
Member

What happened:
yurtctl/yurtadm use 1 replicas Deployment to deploy yurt-controller-manager. Under such circumstances, if the node where yurt-controller-manager deployed shutdowns, the node won't turn into NotReady state, so the yurt-controller-manager won't be re scheduled which may cause issues.

What you expected to happen:
As the yurt-controller-manager is a replacement of the NodeLifecycleController in kube-controller-manager, which is usually
deployed as a static pod on each control plane node.

Maybe the yurt-controller-manager should follow the same deployment way (Daemonset or static pod)?

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • OpenYurt version:
  • Kubernetes version (use kubectl version):
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

others
/kind question

@DrmagicE DrmagicE added the kind/question kind/question label May 24, 2022
@rambohe-ch
Copy link
Member

@DrmagicE Thanks for raising the issue. At present we can use deployment.replicas=2 in order to make the ycm high availbility.

btw: we are now reforming ycm, remove NodeLifeCycle controller from ycm and put NodeLifeCycle controller back to kcm.
issue reference link: #776

@DrmagicE
Copy link
Member Author

@rambohe-ch Thanks for your quick response. I would try daemonset for now and looking forward to the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question kind/question
Projects
None yet
Development

No branches or pull requests

2 participants