[feature request] Command convert of yurtctl support param for kubelet service kubeadm conf

[liangyuanpeng]

What would you like to be added:
Command convert of yurtctl support param for kubelet service kubeadm conf

Why is this needed:
In centos, 10-kubeadm.conf save in /usr/lib/systemd/system/kubelet.service.d/10-kubeadm.conf and yurtctl convert use /etc/systemd/system/kubelet.service.d/10-kubeadm.conf by default .

I want to solve this problem And i have a question about this param name->Do you think the name kubelet-service-kubeadm-conf-path will be too long? Thanks any !

[charleszheng44]

+1 for this feature. I think we can have a shorter command-line option name, like kubeadm-conf-path, and a detailed description, like "The path to the kubeadm configuration file that is used by the kubelet service to join the cluster. N.B. the path on different Linux distro may vary"

[rambohe-ch]

@liangyuanpeng I think it's a good feature. and the parameter of kubelet service conf path does not only for kubeadm tool, other tools may also need this parameter. so how about kubelet-service-conf-path for parameter name? @charleszheng44

[liangyuanpeng]

@liangyuanpeng I think it's a good feature. and the parameter of kubelet service conf path does not only for kubeadm tool, other tools may also need this parameter. so how about kubelet-service-conf-path for parameter name? @charleszheng44

I'm not sure if kubea-conf-path will cause ambiguity, maybe it will be make people think of kubeadm init config file and kubelet-service-conf-path seem like not related to kubeadm. I can think of another name is ks-kubeadm-conf-path. (ks->kubelet service)

I have developed functional content, i will create a PR when we decided on the name! Thanks for your reply.

[charleszheng44]

@liangyuanpeng I think it's a good feature. and the parameter of kubelet service conf path does not only for kubeadm tool, other tools may also need this parameter. so how about kubelet-service-conf-path for parameter name? @charleszheng44

Which tool would also use the 10-kubeadm.conf? I thought we revise the 10-kubeadm.conf only for pointing to the kubelet.conf associated to the yurthub.

[rambohe-ch]

@liangyuanpeng I think it's a good feature. and the parameter of kubelet service conf path does not only for kubeadm tool, other tools may also need this parameter. so how about kubelet-service-conf-path for parameter name? @charleszheng44

Which tool would also use the 10-kubeadm.conf? I thought we revise the 10-kubeadm.conf only for pointing to the kubelet.conf associated to the yurthub.

@charleszheng44 @liangyuanpeng 10-kubeadm.conf is system service conf file for kubelet component, and now other tool(like minikube) may also make up the same name kubelet service file(10-kubeadm.conf), so i think it's good definition without kubeadm word in new parameter. then kubelet-service-conf-path maybe a good selection.

[rambohe-ch]

@liangyuanpeng I think it's a good feature. and the parameter of kubelet service conf path does not only for kubeadm tool, other tools may also need this parameter. so how about kubelet-service-conf-path for parameter name? @charleszheng44

I'm not sure if kubea-conf-path will cause ambiguity, maybe it will be make people think of kubeadm init config file and kubelet-service-conf-path seem like not related to kubeadm. I can think of another name is ks-kubeadm-conf-path. (ks->kubelet service)

I have developed functional content, i will create a PR when we decided on the name! Thanks for your reply.

@liangyuanpeng thank you for your quick response, and @Peeknut has another pr that has revised node convert and revert, so your pr may need to rebase it when pr is creating.

[rambohe-ch]

@charleszheng44 @liangyuanpeng by the way, yurtctl maybe need some statement like only support to convert or revert node that kubelet is managed by system service. if run kubelet directly by binary file, yurtctl may not support it.

[liangyuanpeng]

Thanks for your reply and i just really used kubeadm-conf-path for param name and it's satisfying enough.

, and @Peeknut has another pr that has revised node convert and revert, so your pr may need to rebase it when pr is creating.

So pr of this issue should need to be after refactor: the node convert/revert feature merged , right?

by the way, yurtctl maybe need some statement like only support to convert or revert node that kubelet is managed by system service. if run kubelet directly by binary file, yurtctl may not support it.

Thanks remind, I think we can state this in the documentation/ yurtctl description of help.

[rambohe-ch]

Thanks for your reply and i just really used kubeadm-conf-path for param name and it's satisfying enough.

ok, kubeadm-conf-path maybe the same meaning as kubelet service conf path, so kubeadm-conf-path can be accepted, and please add The path of kubelet service conf for kubeadm-conf-path usage.