You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What would you like to be added:
In NodeLifeCycle and PodBinding controller of yurt-manager component, spec.nodeName IndexField has been used at present, and FieldIndexer setting is only needed to configured only once, and now is configured in NodeLifeCycle controller as following:
klog.Errorf("could not register spec.NodeName field indexers for nodelifecycle controller, %v", err)
returnerr
}
This FieldIndexer setting is shared by two controllers, maybe it is a good idea to move this sharing setting as a public setting instead of configuring in NodeLifeCycle controller.
Because in some scenarios, users like to disable NodeLifeCycle controller, so FieldIndexer setting will not be configured, then an error happens in PodBinding controller as following:
E1113 13:40:14.428554 1 podbinding_controller.go:180] pod-binding-controller: failed to get podList for node(izbp13108hhdvq7ver655tz), Index with name field:spec.nodeName does not exist
E1113 13:40:14.428590 1 controller.go:317] setup/controller/pod-binding-controller "msg"="Reconciler error" "error"="Index with name field:spec.nodeName does not exist" "name"="izbp13108hhdvq7ver655tz" "namespace"=""
others
/kind feature
The text was updated successfully, but these errors were encountered:
What would you like to be added:
In
NodeLifeCycle
andPodBinding
controller of yurt-manager component,spec.nodeName
IndexField has been used at present, and FieldIndexer setting is only needed to configured only once, and now is configured inNodeLifeCycle
controller as following:openyurt/pkg/yurtmanager/controller/nodelifecycle/node_lifecycle_controller.go
Lines 332 to 344 in 3636ec0
This FieldIndexer setting is shared by two controllers, maybe it is a good idea to move this sharing setting as a public setting instead of configuring in
NodeLifeCycle
controller.Because in some scenarios, users like to disable
NodeLifeCycle
controller, so FieldIndexer setting will not be configured, then an error happens inPodBinding
controller as following:others
/kind feature
The text was updated successfully, but these errors were encountered: