Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add status information after adding yurtappoverrider #1703

Closed
vie-serendipity opened this issue Sep 16, 2023 · 1 comment
Closed
Labels
kind/feature kind/feature

Comments

@vie-serendipity
Copy link
Member

What would you like to be added:
Supplement status information on YurtAppSet/YurtAppDaemon #1702 after adding YurtAppOverrider #1684

  • WorkloadSummaries: It represents information about the workload of the nodepool, such as available condition

  • OverriderRef: The name of the overrider to which it is bound

Why is this needed:

  1. Because of the addition of multiple region configuration render engine(YurtAppOverrider), we need to add the appropriate fields to yurtappset and yurtappdaemon, as well as some additional status information in order to satisfy the needs of [feature request] Add more information about availability in the status of the yurtappset #1543
  2. This change only add some fields, we keep all the previous fields. So it does not affect the previous user's use, and updating version is not required

others
/kind feature

@vie-serendipity vie-serendipity added the kind/feature kind/feature label Sep 16, 2023
@rambohe-ch
Copy link
Member

@vie-serendipity I think it is reasonable to add new fields into status of yurtappset and yurtappdaemon. at the same time, yurtappset.Status.PoolReplicas and yurtappdaemon.Status.NodePools should be deprecated in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants