Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]optimize yurtadm reset command #1058

Closed
rambohe-ch opened this issue Nov 16, 2022 · 2 comments · Fixed by #1075
Closed

[feature request]optimize yurtadm reset command #1058

rambohe-ch opened this issue Nov 16, 2022 · 2 comments · Fixed by #1075
Assignees
Labels
kind/feature kind/feature

Comments

@rambohe-ch
Copy link
Member

What would you like to be added:
please optimize yurtadm reset command by invoking kubeadm reset instead of importing code of kubeadm reset
as a plus, clean up the code that is not needed anymore in pkg/yurtadm dir.

Why is this needed:
yurtadm join command is optimized based on the kubeadm join command, it's natural that optimize yurtadm reset command in the same way.

others
/kind feature

@YTGhost
Copy link
Member

YTGhost commented Nov 16, 2022

I want to do this after completely finish yurtadm join refactoring

@rambohe-ch
Copy link
Member Author

/assign @YTGhost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants