-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Disabling nodelifecycle affects k8s cloud node #1001
Comments
Well, we actually disable the native nodelifecycle controller, but it does not mean we will lose its capability, because we integrate nodelifecycle controller into yurt-controller-manager, you can find it here: https://github.com/openyurtio/openyurt/tree/master/pkg/controller/nodelifecycle. The reason why we disable the native nodelifecycle controller and use the counter-part in yurt-controller-manager is that, as you said, "manage the OpenYurt cloud and edge nodes based on label or something else", which is annotation in fact. In join nodes, we will add annotation However, it seems to be a temporary solution. We have came out another way which can be compatible with native nodelifecycle controller, see #776. |
this makes more sense to me! thanks for the intel.
|
@Congrool do you guys keep this open? now i know that there is an activity against this question, so i am good to close this question. |
Sure, we can keep this issue open until #776 has been completed. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is just a question that we like to bring up here.
We are not sure if this is constraint or limitation.
What happened:
Official install document requires to disable
nodelifecycle
feature forYurt-Controller-Manager
.This can affect Kubernetes nodes management, if user wants to manage k8s nodes aligned with OpenYurt.
Detailed procedure: https://openyurt.io/docs/next/installation/openyurt-prepare/#2-kube-controller-manager-adjustment
What you expected to happen:
nodelifecycle
should not be disabled,Yurt-Controller-Manager
should be able to abstract and manage the OpenYurt cloud and edge nodes based on label or something else.So that Kubernetes nodes can align with OpenYurt to keep Kuernetes Feature.
Environment:
kubectl version
): v1.22.13cat /etc/os-release
): Ubuntu 20.04.4 LTSuname -a
): 5.15.0-46-generic set the server-addr before deploying the yurthub #49~20.04.1-Ubuntu SMPothers
/kind question
The text was updated successfully, but these errors were encountered: