Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test bytecode resilience to attribute name change / op name change #70

Closed
GleasonK opened this issue Sep 1, 2022 · 1 comment
Closed

Test bytecode resilience to attribute name change / op name change #70

GleasonK opened this issue Sep 1, 2022 · 1 comment
Assignees
@GleasonK
Labels
Integrations

Comments

@GleasonK
Copy link
Member

GleasonK commented Sep 1, 2022

From this discussion in #60.

Test and document in bytecode.md the current result of changing attr names and op names. Note how this will this impact forward/backward compatibility.
@GleasonK GleasonK self-assigned this Sep 1, 2022
@GleasonK GleasonK mentioned this issue Sep 1, 2022
Merged
@GleasonK
Copy link
Member Author

Did some testing on:
main...GleasonK:stablehlo:compat-testing

It seems that bytecode stability is comparable to generic printed IR. Changes to the mnemonic or attribute / type names will cause backward incompatibilities when deserializing bytecode. However changes to the C++ API will not cause cause incompatibilities in deserialization.

This has all been captured in #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GleasonK GleasonK

Labels
Integrations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GleasonK